From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Ian Munsie <imunsie@au1.ibm.com>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH 3/3] powerpc: icswx: Simple ACOP fault handler for both book3e and book3s parts.
Date: Tue, 09 Aug 2011 10:15:29 -0500 [thread overview]
Message-ID: <1312902929.29273.10.camel@pasglop> (raw)
In-Reply-To: <500B0F0F-658A-4B95-8BEC-978D738A926F@kernel.crashing.org>
On Tue, 2011-08-09 at 00:26 -0500, Kumar Gala wrote:
> > + /* Some implementations leave us a hint for the CT */
> > + ct = ICSWX_GET_CT_HINT(error_code);
> > + if (ct < 0) {
> > + /* we have to peek at the instruction work to figure out CT */
> > + union cop_ccw ccw;
>
> don't use a union, we don't do this for any other place we decode instructions (just use shift/mask). Utilize ppc-opcode.h
Except that the union here is -not- the instruction, but the content of
the RS register :-)
Cheers,
Ben.
next prev parent reply other threads:[~2011-08-09 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 22:26 powerpc: Get icswx to work on both Book3s and Book3e platforms Jimi Xenidis
2011-08-08 22:26 ` [PATCH 1/3] powerpc: Split ICSWX ACOP and PID processing Jimi Xenidis
2011-08-09 5:20 ` Kumar Gala
2011-08-08 22:26 ` [PATCH 2/3] powerpc: book3e: Add ICSWX/ACOP support to Book3e cores like A2 Jimi Xenidis
2011-08-09 5:22 ` Kumar Gala
2011-08-08 22:26 ` [PATCH 3/3] powerpc: icswx: Simple ACOP fault handler for both book3e and book3s parts Jimi Xenidis
2011-08-09 5:26 ` Kumar Gala
2011-08-09 15:00 ` Jimi Xenidis
2011-08-09 15:15 ` Benjamin Herrenschmidt [this message]
2011-08-09 15:24 ` Jimi Xenidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312902929.29273.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=galak@kernel.crashing.org \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.