From: Joshua Lock <josh@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command
Date: Tue, 09 Aug 2011 09:25:07 -0700 [thread overview]
Message-ID: <1312907112.2265.1.camel@scimitar> (raw)
In-Reply-To: <1312897353.14274.294.camel@rex>
On Tue, 2011-08-09 at 14:42 +0100, Richard Purdie wrote:
> When running bitbake in -k mode, the last command might succeed but we
> still need to preserve any previous failure codes.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
> diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
> index 63b8dc6..7a2681d 100644
> --- a/bitbake/lib/bb/ui/knotty.py
> +++ b/bitbake/lib/bb/ui/knotty.py
> @@ -188,7 +188,8 @@ def main(server, eventHandler):
> logger.error("Command execution failed: %s", event.error)
> break
> if isinstance(event, bb.command.CommandExit):
> - return_value = event.exitcode
> + if not return_value:
> + return_value = event.exitcode
> continue
> if isinstance(event, bb.cooker.CookerExit):
> break
>
>
>
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
prev parent reply other threads:[~2011-08-09 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 13:42 [PATCH] bitbake/ui/knotty: Ensure previous failures aren't masked by a final successful command Richard Purdie
2011-08-09 16:25 ` Joshua Lock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312907112.2265.1.camel@scimitar \
--to=josh@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.