From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mandeep Singh Baines <msb@chromium.org>,
linux-kernel@vger.kernel.org,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Joachim Eastwood <manabian@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Herbert Xu <herbert@gondor.hengli.com.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
GeertUytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] treewide: Update sha_transform
Date: Tue, 09 Aug 2011 17:57:28 -0700 [thread overview]
Message-ID: <1312937848.11924.44.camel@Joe-Laptop> (raw)
In-Reply-To: <CA+55aFwHEoDkWr6Mh=r1KG4MLRbY0_iVF-v3BPkK+zhxkriHdw@mail.gmail.com>
On Tue, 2011-08-09 at 08:41 -0700, Linus Torvalds wrote:
> On Tue, Aug 9, 2011 at 1:58 AM, Joe Perches <joe@perches.com> wrote:
> > Eliminate possible sha_transform unaligned accesses to data by copying
> > data to an aligned __u32 array if necessary.
> This is wrong. Not only does it double the stack space, when I tried
> it for git it just made things slower. So don't do it.
Maybe the aligned copy should be in an
#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS block.
Maybe Mandeep could test aligned/unaligned speeds
for his board?
next prev parent reply other threads:[~2011-08-10 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 23:07 [PATCH] lib/sha1: remove memsets and allocate workspace on the stack Mandeep Singh Baines
2011-08-08 23:45 ` Joe Perches
2011-08-09 5:52 ` Mandeep Singh Baines
2011-08-09 8:58 ` [PATCH] treewide: Update sha_transform Joe Perches
2011-08-09 15:41 ` Linus Torvalds
2011-08-10 0:57 ` Joe Perches [this message]
2011-08-09 7:01 ` [PATCH] lib/sha1: remove memsets and allocate workspace on the stack Geert Uytterhoeven
2011-08-08 23:50 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312937848.11924.44.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=msb@chromium.org \
--cc=nico@fluxnic.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=schwab@linux-m68k.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.