From: Alexander Simon <alexander.simon@saxnet.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] cfg80211: Add cfg80211_get_bss_ht to also match HT configuration
Date: Wed, 10 Aug 2011 19:50:57 +0200 [thread overview]
Message-ID: <1312998657.3128.45.camel@alex-2> (raw)
In-Reply-To: <1312992332.4325.22.camel@jlt3.sipsolutions.net>
Am Mittwoch, den 10.08.2011, 18:05 +0200 schrieb Johannes Berg:
> On Wed, 2011-08-10 at 17:48 +0200, Alexander Simon wrote:
> > Am Mittwoch, den 10.08.2011, 15:53 +0200 schrieb Johannes Berg:
> > > On Mon, 2011-08-08 at 14:04 +0200, Alexander Simon wrote:
> > >
> > > > +struct cfg80211_bss *cfg80211_get_bss_ht(struct wiphy *wiphy,
> > > > + struct ieee80211_channel *channel,
> > > > + const u8 *bssid,
> > > > + const u8 *ssid, size_t ssid_len,
> > > > + u16 capa_mask, u16 capa_val,
> > > > + enum nl80211_channel_type channel_type);
> > >
> > > indentation? Also, you really need kernel-doc for this.
> > Pardon me, but I don't know what you mean... I just browsed
> > Documentation/networking. Could you point me the exact file, please?
>
> Documentation/kernel-doc-nano-HOWTO.txt maybe?
Uh, okay...
I thought as there is no documentation for cfg80211_get_bss, there was
no need to document the _ht version...
The problem I'm facing here is that I really *need* to check the HT mode
_inside_ the loop. Hence i need a _ht version.
OR I could change cfg80211_get_bss only, causing to add the new
parameters in *all* calls of cfg80211_get_bss... Whatever you prefer.
To conclude this:
* I'll write a _ht version that has a check_ht bool
* if (check_ht == 1), match channel_type parameter
* _ht version calls non-ht with check_ht = 0
* documentation for _ht (for non-ht also???)
Indentation will be fixed, of course.
Alex
next prev parent reply other threads:[~2011-08-10 17:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 12:02 [PATCH 1/4] nl80211: Parse channel type attribute in an IBSS join request Alexander Simon
2011-08-08 12:04 ` [PATCH 2/4] cfg80211: Add cfg80211_get_bss_ht to also match HT configuration Alexander Simon
2011-08-10 13:53 ` Johannes Berg
2011-08-10 15:48 ` Alexander Simon
2011-08-10 16:05 ` Johannes Berg
2011-08-10 17:50 ` Alexander Simon [this message]
2011-08-12 12:32 ` Johannes Berg
2011-08-12 14:20 ` Alexander Simon
2011-08-08 12:09 ` [PATCH 3/4] mac80211: Add HT helper functions Alexander Simon
2011-08-10 13:54 ` Johannes Berg
2011-08-10 13:55 ` Johannes Berg
2011-08-08 12:10 ` [PATCH 4/4] mac80211: Add HT operation modes for IBSS Alexander Simon
2011-08-10 14:03 ` Johannes Berg
2011-08-10 15:31 ` Alexander Simon
2011-08-12 12:35 ` Johannes Berg
2011-08-12 14:25 ` Alexander Simon
2011-08-13 16:05 ` Felix Fietkau
2011-08-10 13:50 ` [PATCH 1/4] nl80211: Parse channel type attribute in an IBSS join request Johannes Berg
2011-08-23 19:39 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312998657.3128.45.camel@alex-2 \
--to=alexander.simon@saxnet.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.