All of lore.kernel.org
 help / color / mirror / Atom feed
From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Fix Thumb-2 undef handling for mixed-arch kernels
Date: Tue, 16 Aug 2011 15:58:14 +0100	[thread overview]
Message-ID: <1313506694.2235.15.camel@computer2> (raw)
In-Reply-To: <1313504053-27873-1-git-send-email-dave.martin@linaro.org>

On Tue, 2011-08-16 at 15:14 +0100, Dave Martin wrote:
> In kernels which support v6 and v7 platforms in a single binary
> such as omap2plus_defconfig for example, undefined instruction
> exceptions taken on Thumb instructions are not processed correctly,
> because the kernel assumes at build-time that Thumb-2 won't be
> supported in userspace.
> 
> This series implements a workaround, by allowing the __und_usr
> handler to check the CPU architecture at runtime, in affected
> kernels.
> 
> Changes since RFC:
>   * Renamed the global variable to __cpu_architecture and provided
>     cpu_architecture() as in inline function in <asm/system.h>.
>     This brings back the old API, but more efficiently.
>   * Dropped all the patches required to handle the reverted API
>     change.
>   * cpu_architecture is now declared __pure, which may lead to
>     slightly more efficient code in some cases.
>   * Added BUG_ON() to cpu_architecture() so that if
>     __cpu_architecture is not set early enough, it gets noticed.
> 
> Thanks to Tixy and Nicolas Pitre for their helpful feedback which
> helped slim down this series.
> 
> Dave Martin (3):
>   ARM: Make cpu_alignment into a global variable
>   ARM: entry: Remove unnecessary masking when decoding Thumb-2
>     instructions
>   ARM: entry: Fix Thumb-2 undef handling for multi-CPU kernels
> 
>  arch/arm/include/asm/system.h |   11 +++++++++-
>  arch/arm/kernel/entry-armv.S  |   44 ++++++++++++++++++++++++++++++++++++----
>  arch/arm/kernel/setup.c       |    5 +++-
>  3 files changed, 53 insertions(+), 7 deletions(-)
> 

Looks good to me.

-- 
Tixy

  parent reply	other threads:[~2011-08-16 14:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16 14:14 [PATCH 0/3] Fix Thumb-2 undef handling for mixed-arch kernels Dave Martin
2011-08-16 14:14 ` [PATCH 1/3] ARM: Make cpu_alignment into a global variable Dave Martin
2011-08-16 16:15   ` Nicolas Pitre
2011-08-16 16:21     ` Dave Martin
2011-08-17 11:31   ` Sergei Shtylyov
2011-08-17 13:37     ` Dave Martin
2011-08-16 14:14 ` [PATCH 2/3] ARM: entry: Remove unnecessary masking when decoding Thumb-2 instructions Dave Martin
2011-08-16 16:17   ` Nicolas Pitre
2011-08-16 16:21     ` Dave Martin
2011-08-16 14:14 ` [PATCH 3/3] ARM: entry: Fix Thumb-2 undef handling for multi-CPU kernels Dave Martin
2011-08-16 14:51   ` Tixy
2011-08-16 15:47     ` Nicolas Pitre
2011-08-16 16:05       ` Dave Martin
2011-08-16 16:14         ` Nicolas Pitre
2011-08-16 16:20           ` Dave Martin
2011-08-16 14:58 ` Tixy [this message]
2011-08-16 16:06   ` [PATCH 0/3] Fix Thumb-2 undef handling for mixed-arch kernels Dave Martin
2011-08-16 16:43     ` Tixy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313506694.2235.15.camel@computer2 \
    --to=tixy@yxit.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.