From: tixy@yxit.co.uk (Tixy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] amba: consolidate PrimeCell magic
Date: Thu, 18 Aug 2011 11:08:07 +0100 [thread overview]
Message-ID: <1313662087.2254.31.camel@computer2> (raw)
In-Reply-To: <20110817184905.GA11221@n2100.arm.linux.org.uk>
On Wed, 2011-08-17 at 19:49 +0100, Russell King - ARM Linux wrote:
> On Wed, Aug 17, 2011 at 12:03:57PM -0500, H Hartley Sweeten wrote:
> > > + cellid = amba_get_pid((void __iomem *)((u32)base & PAGE_MASK), SZ_4K);
> >
> > This produces a sparse warning. But, the same warning was present with the
> > old code.
> >
> > arch/arm/common/vic.c:353:49: warning: cast removes address space of expression
>
> That's prabably because casting from a pointer to a u32 (unsigned int)
> isn't the best thing to do. Casting to unsigned long is much better,
> and iirc doesn't provoke such a sparse warning.
Is there any reason not to use uintptr_t for things like this?
next prev parent reply other threads:[~2011-08-18 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 8:30 [PATCH v3] amba: consolidate PrimeCell magic Linus Walleij
2011-08-17 8:37 ` Jassi Brar
2011-08-17 17:03 ` H Hartley Sweeten
2011-08-17 18:49 ` Russell King - ARM Linux
2011-08-18 7:56 ` Linus Walleij
2011-08-18 10:08 ` Tixy [this message]
2011-08-18 10:26 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313662087.2254.31.camel@computer2 \
--to=tixy@yxit.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.