From: Peter Zijlstra <peterz@infradead.org>
To: "Jan H. Schönherr" <schnhrr@cs.tu-berlin.de>
Cc: Ingo Molnar <mingo@elte.hu>, Paul Turner <pjt@google.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] sched: Handle on_list ancestor in list_add_leaf_cfs_rq()
Date: Tue, 23 Aug 2011 20:56:43 +0200 [thread overview]
Message-ID: <1314125803.8002.91.camel@twins> (raw)
In-Reply-To: 1313503666-13726-3-git-send-email-schnhrr@cs.tu-berlin.de
On Tue, 2011-08-23 at 20:53 +0200, Peter Zijlstra wrote:
> LIST_HEAD(leaf_queue);
>
> for_each_sched_entity(se) {
> if (se->on_rq)
> break;
> cfs_rq = cfs_rq_of(se);
> enqueue_entity(cfs_rq, se, flags);
> flags = ENQUEUE_WAKEUP;
> if (cfs_rq->nr_running == 1)
> leaf_add_queue(cfs_rq, &leaf_queue);
> }
> /* XXX does ->on_rq imply ->on_list ? */
> if (se->on_list)
> leaf_splice_queue(cfs_rq, &leaf_queue);
Bah, se can be NULL here, still needing some extra foo.
prev parent reply other threads:[~2011-08-23 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 14:07 [PATCH v3 0/2] sched: Enforce order of leaf CFS runqueues Jan H. Schönherr
2011-08-16 14:07 ` [PATCH v3 1/2] rcu: More rcu-variants for list manipulation Jan H. Schönherr
2011-08-23 15:37 ` Paul E. McKenney
2011-08-16 14:07 ` [PATCH v3 2/2] sched: Handle on_list ancestor in list_add_leaf_cfs_rq() Jan H. Schönherr
2011-08-23 18:53 ` Peter Zijlstra
2011-08-24 21:27 ` "Jan H. Schönherr"
2011-08-24 21:32 ` Paul Turner
2011-08-24 22:40 ` "Jan H. Schönherr"
2011-08-30 13:35 ` Peter Zijlstra
2011-08-23 18:56 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314125803.8002.91.camel@twins \
--to=peterz@infradead.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pjt@google.com \
--cc=schnhrr@cs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.