From: Stephen Smalley <sds@tycho.nsa.gov>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Eric Paris <eparis@parisplace.org>,
Jarkko Sakkinen <jarkko.sakkinen@intel.com>,
Casey Schaufler <casey@schaufler-ca.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] Smack: SMACK_IOCLOADACCESS
Date: Fri, 26 Aug 2011 13:36:26 -0400 [thread overview]
Message-ID: <1314380186.25778.30.camel@moss-pluto> (raw)
In-Reply-To: <20110826141410.3d639231@lxorguk.ukuu.org.uk>
On Fri, 2011-08-26 at 14:14 +0100, Alan Cox wrote:
> > good in that it only takes 1 syscall and ours takes 2. Your interface
> > is bad in that it is ioctl and we are told since birth that we must
> > hate them no matter what (not that read/write is really any
> > different). It isn't the same method the only other LSM I know about
> > uses. It can only every return one value (ok, I know ioctl can be
> > made to do anything at all)
>
> I'm all in favour of the use of brains rather than the cult of ioctl
> hating. You can design bad ioctls and good ones. Also ioctl is pretty
> much unique in being bidirectional, it allows a query/respose action
> without having to worry about whether the respose is the one to your
> query or another parallel query.
The transaction ops achieve that property as well - the response is
stored in an open file private buffer and thus can only correspond to a
request written to that same open file instance.
--
Stephen Smalley
National Security Agency
next prev parent reply other threads:[~2011-08-26 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 5:52 [PATCH] Smack: SMACK_IOCLOADACCESS Jarkko Sakkinen
2011-08-26 12:50 ` Eric Paris
2011-08-26 13:14 ` Alan Cox
2011-08-26 17:36 ` Stephen Smalley [this message]
2011-08-26 16:05 ` Sakkinen, Jarkko
2011-08-26 17:01 ` Eric Paris
2011-08-26 21:59 ` Casey Schaufler
2011-08-27 0:16 ` Eric Paris
2011-08-27 5:57 ` Sakkinen, Jarkko
2011-08-26 16:26 ` Casey Schaufler
2011-08-26 17:28 ` Stephen Smalley
2011-08-26 21:47 ` Casey Schaufler
2011-08-26 17:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314380186.25778.30.camel@moss-pluto \
--to=sds@tycho.nsa.gov \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=casey@schaufler-ca.com \
--cc=eparis@parisplace.org \
--cc=jarkko.sakkinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.