From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath: systemd unit file
Date: Thu, 01 Sep 2011 09:04:31 +0200 [thread overview]
Message-ID: <1314860671.14056.83.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <4E5F24DE.50004@suse.de>
> > +[Unit]
> > +Description=Device-Mapper Multipath Device Controller
> > +Before=iscsi.service iscsid.service
> > +After=syslog.target
> > +
> > +[Service]
> > +Type=forking
> > +PIDFile=/var/run/multipathd.pid
> > +ExecStart=/sbin/multipathd
> > +ExecReload=/bin/kill -HUP $MAINPID
> > +#ExecStop=/path/to/scrip delete-me if not necessary
> > +
> > +[Install]
> > +WantedBy=multi-user.target
> >
> Hmm. First of all, I'm trying to get rid of the PID file, as with it
> it's quite hard to start multipathing when /var/run isn't mounted.
> Plus it's not actually needed; everything can be done via multipathd
> -k nowadays.
>
Agreed
> So may I suggest to use
> ExecReload=/sbin/multipathd -k'reconfigure'
>
Or even:
ExecReload=multipathd reconfigure
Regards,
--
Christophe Varoqui
OpenSVC - Tools to scale
http://www.opensvc.com/
next prev parent reply other threads:[~2011-09-01 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 3:00 [PATCH] multipath: systemd unit file Benjamin Marzinski
2011-09-01 6:23 ` Hannes Reinecke
2011-09-01 7:04 ` Christophe Varoqui [this message]
2011-09-01 7:11 ` Hannes Reinecke
2011-09-01 17:08 ` [PATCH v2] " Benjamin Marzinski
2011-09-01 14:46 ` [PATCH] " Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314860671.14056.83.camel@lapoo.opensvc.com \
--to=christophe.varoqui@gmail.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.