From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call
Date: Tue, 06 Sep 2011 13:17:41 +0300 [thread overview]
Message-ID: <1315304261.1930.7.camel@deskari> (raw)
In-Reply-To: <CAP5A+B8j8QHOOXp5H2d=rsEgn+YOdWcqB9_SjZ=aE3U4jovLNA@mail.gmail.com>
On Tue, 2011-09-06 at 11:38 +0530, K, Mythri P wrote:
> >> Did you consider how the code would look if the function pointers
> were
> >> just included into struct hdmi_ip_data, without any ops struct at
> all?
> >>
> I tried without ops structure , but then using it in dss_features to
> initialize would be a problem so i have moved it to ti_hdmi.h.
I'm fine with the ops struct, but I don't see why it would be a problem
without it. You'd just pass the hdmi_ip_data to dss_features, which
would initialize it.
Tomi
next prev parent reply other threads:[~2011-09-06 10:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 10:47 [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent mythripk
2011-09-02 10:47 ` [PATCH v3 01/10] OMAP4: DSS: HDMI: HDMI clean up to pass base_address mythripk
2011-09-02 10:47 ` [PATCH v3 02/10] OMAP4: DSS: HDMI: Move pll and video configuration mythripk
2011-09-02 10:47 ` [PATCH v3 03/10] OMAP4: DSS: HDMI: Use specific HDMI timings structure mythripk
2011-09-02 10:47 ` [PATCH v3 04/10] OMAP4: DSS: HDMI: Move IP independent common header mythripk
2011-09-02 10:47 ` [PATCH v3 05/10] OMAP4 : DSS : HDMI : Move the EDID portion from HDMI mythripk
2011-09-02 10:47 ` [PATCH v3 06/10] OMAP4: DSS2: HDMI: Split the HDMI driver to DSS and IP mythripk
2011-09-02 10:47 ` [PATCH v3 07/10] OMAP4: DSS: HDMI: Rename the functions in HDMI IP mythripk
2011-09-02 10:47 ` [PATCH v3 08/10] OMAP4: DSS: HDMI: Move the common HDMI header file mythripk
2011-09-02 10:47 ` [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call mythripk
2011-09-02 10:47 ` [PATCH v3 10/10] OMAP4: DSS: Rename hdmi_omap4_panel.c to hdmi_panel.c mythripk
2011-09-05 5:40 ` [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call Semwal, Sumit
2011-09-05 11:01 ` Tomi Valkeinen
2011-09-05 17:33 ` K, Mythri P
2011-09-06 6:08 ` K, Mythri P
2011-09-06 10:17 ` Tomi Valkeinen [this message]
2011-09-06 11:25 ` K, Mythri P
2011-09-06 12:45 ` Tomi Valkeinen
2011-09-06 13:05 ` K, Mythri P
2011-09-05 7:40 ` [PATCH v3 00/10]HDMI: Split hdmi.c in DSS to seperate OMAP dependent Tomi Valkeinen
2011-09-05 10:35 ` K, Mythri P
2011-09-05 10:41 ` Tomi Valkeinen
2011-09-05 12:15 ` Tomi Valkeinen
2011-09-05 13:22 ` K, Mythri P
2011-09-06 9:39 ` K, Mythri P
2011-09-06 11:28 ` K, Mythri P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315304261.1930.7.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.