All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/5] gfs_controld: Remove dead code from loop()
Date: Tue, 06 Sep 2011 13:43:26 +0100	[thread overview]
Message-ID: <1315313006.2741.23.camel@menhir> (raw)
In-Reply-To: <1315310417-4833-4-git-send-email-anprice@redhat.com>

Hi,

Those all look good to me,

Steve.

On Tue, 2011-09-06 at 13:00 +0100, Andrew Price wrote:
> This patch removes an if statement where the true branch is never taken.
> At this point in the code, poll_timeout could only be 500 or -1.
> 
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
>  group/gfs_controld/main.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/group/gfs_controld/main.c b/group/gfs_controld/main.c
> index 252965a..aa38839 100644
> --- a/group/gfs_controld/main.c
> +++ b/group/gfs_controld/main.c
> @@ -1286,9 +1286,6 @@ static void loop(void)
>  			if (dmsetup_wait) {
>  				if (poll_timeout == -1)
>  					poll_timeout = 1000;
> -			} else {
> -				if (poll_timeout == 1000)
> -					poll_timeout = -1;
>  			}
>  		}
>  		query_unlock();




  reply	other threads:[~2011-09-06 12:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06 12:00 [Cluster-devel] [PATCH 1/5] gfs2_edit: Initialize metafds fully in savemetaopen Andrew Price
2011-09-06 12:00 ` [Cluster-devel] [PATCH 2/5] libgfs2: clean up some dead code in gfs2_writei Andrew Price
2011-09-06 12:00 ` [Cluster-devel] [PATCH 3/5] libgfs2: Remove dead code from gfs2_get_leaf Andrew Price
2011-09-06 12:00 ` [Cluster-devel] [PATCH 4/5] gfs_controld: Remove dead code from loop() Andrew Price
2011-09-06 12:43   ` Steven Whitehouse [this message]
2011-09-06 14:36   ` David Teigland
2011-09-06 12:00 ` [Cluster-devel] [PATCH 5/5] gfs2_edit: Fix segfault in find by resource group Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315313006.2741.23.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.