Re: [PATCH 0/2] QoS headers for mesh

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2011-09-07 at 11:36 -0700, Javier Cardona wrote:

> > So after looking at this again -- what I'd much rather see instead of
> > the second patch, and what will also require fewer changes, is *only*
> > doing the change to ieee80211_set_qos_hdr(). Then, if the peer is a QoS
> > station, we'll get the right header -- if it isn't then we can't really
> > mesh with it but we'll accept that for legacy reasons (for now).
> >
> > I'd rather not send QoS frames to mesh stations that don't advertise QoS
> > capability, and I'd also rather not have to worry about sending QoS
> > frames when we don't actually support it locally.
> 
> OK.  If QoS support is mandatory for mesh stations, then definitely
> that's the way to go.  We'll have to investigate how to advertise QoS
> for mesh interfaces:  this is currently not happening even though all
> the hardware we use for mesh supports it.

Right. I was thinking ... we could also just pretend all mesh stations
are QoS capable and always set the WLAN_STA_WME flag for them. That'd
still be cleaner in terms of how the current code flow works that adds
the QoS header and also wouldn't require any changes other than the one
to ieee80211_set_qos_hdr() (and the one to set WLAN_STA_WME of course).

johannes