All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex,Shi" <alex.shi@intel.com>
To: "cl@linux.com" <cl@linux.com>, Pekka Enberg <penberg@cs.helsinki.fi>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Chen@kvack.org, Tim C <tim.c.chen@intel.com>,
	Huang@kvack.org, Ying <ying.huang@intel.com>
Subject: [PATCH 1/2] slub: remove obsolete code path in __slab_free() for per cpu partial
Date: Fri, 09 Sep 2011 17:02:41 +0800	[thread overview]
Message-ID: <1315558961.31737.790.camel@debian> (raw)

If there are still some objects left in slab, the slab page will be put
to per cpu partial list. So remove the obsolete code path.


Signed-off-by: Alex Shi <alex.shi@intel.com>
---
 mm/slub.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 492beab..bca8eee 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2526,20 +2526,9 @@ static void __slab_free(struct kmem_cache *s, struct page *page,
 	 */
 	if (was_frozen)
 		stat(s, FREE_FROZEN);
-	else {
-		if (unlikely(!inuse && n->nr_partial > s->min_partial))
+	else if (unlikely(!inuse && n->nr_partial > s->min_partial))
                         goto slab_empty;
 
-		/*
-		 * Objects left in the slab. If it was not on the partial list before
-		 * then add it.
-		 */
-		if (unlikely(!prior)) {
-			remove_full(s, page);
-			add_partial(n, page, 0);
-			stat(s, FREE_ADD_PARTIAL);
-		}
-	}
 	spin_unlock_irqrestore(&n->list_lock, flags);
 	return;
 
-- 
1.7.0



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2011-09-09  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09  9:02 Alex,Shi [this message]
2011-09-09  9:06 ` [PATCH 1/2] slub: remove obsolete code path in __slab_free() for per cpu partial Alex,Shi
2011-09-12 15:24   ` Christoph Lameter
2011-09-13 13:38     ` Shi, Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315558961.31737.790.camel@debian \
    --to=alex.shi@intel.com \
    --cc=Chen@kvack.org \
    --cc=Huang@kvack.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=tim.c.chen@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.