From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from goalie.tycho.ncsc.mil (goalie [144.51.3.250]) by tarius.tycho.ncsc.mil (8.13.1/8.13.1) with ESMTP id p89NPYv6010510 for ; Fri, 9 Sep 2011 19:25:34 -0400 Received: from cp-out9.libero.it (localhost [127.0.0.1]) by msux-gh1-uea01.nsa.gov (8.12.10/8.12.10) with ESMTP id p89NPXeX020003 for ; Fri, 9 Sep 2011 23:25:33 GMT Subject: Re: [RFC] Userspace top-level Makefile (was Re: [PATCH] Fix LIBDIR usage for load_policy) From: Guido Trentalancia To: Eric Paris Cc: Joshua Brindle , Eric Paris , SELinux Mail List Date: Sat, 10 Sep 2011 01:25:19 +0200 In-Reply-To: <4E6A9E26.9080806@redhat.com> References: <1315587716.2170.16.camel@vortex> <1315588656.2170.26.camel@vortex> <1315590383.2170.32.camel@vortex> <1315591143.2170.36.camel@vortex> <1315603187.2482.22.camel@vortex> <4E6A8707.9080602@manicmethod.com> <1315607702.2482.28.camel@vortex> <4E6A9C4D.6010303@redhat.com> <1315609967.2482.39.camel@vortex> <4E6A9E26.9080806@redhat.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <1315610720.2482.42.camel@vortex> Mime-Version: 1.0 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On Fri, 2011-09-09 at 19:15 -0400, Eric Paris wrote: > On 09/09/2011 07:12 PM, Guido Trentalancia wrote: > > On Fri, 2011-09-09 at 19:07 -0400, Eric Paris wrote: > >> On 09/09/2011 06:35 PM, Guido Trentalancia wrote: > >>> The following patch is probably even better as it actually sorts out the > >>> problem rather than just printing out a warning (it can still be > >>> combined with the creation of a top-level README file): > >>> > >>> diff -x '*.po' -x '*.pot' -pru selinux-09092011-orig/checkpolicy/Makefile selinux-09092011-local-headers/checkpolicy/Makefile > >>> --- selinux-09092011-orig/checkpolicy/Makefile 2011-09-09 20:12:55.978662153 +0200 > >>> +++ selinux-09092011-local-headers/checkpolicy/Makefile 2011-09-10 00:21:16.242852130 +0200 > >>> @@ -12,7 +12,7 @@ YACC = bison -y > >>> > >>> CFLAGS ?= -g -Wall -Werror -Wshadow -O2 -pipe -fno-strict-aliasing > >>> > >>> -override CFLAGS += -I. -I${INCLUDEDIR} > >>> +override CFLAGS += -I. -I../libsepol/include -I${INCLUDEDIR} > >> > >> I haven't checked, but can the makefiles then work when there is no > >> ../libsepol/include? > > > > If ../libsepol/include does not exist and libsepol headers are not > > installed under the standard location (${INCLUDEDIR}), then the above is > > going to fail. > > > > But why should libsepol/include be missing from git in the first > > place ?? > > I agree that they must be in one or the other for it to build. A number > of distros build these packages separately, rather than all at once. > Thus there would be no ../libsepol/include directory at all, but the > headers should be picked up by -I$(INCLUDEDIR). As long as gcc doesn't > care that the directory doesn't exist, I actually like it. > > -Eric gcc should only care that at least one version of the file can be found if #include'd. It still needs to be tested though. Can you try building the whole userspace git using that patch ? Regards, Guido -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.