All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hills <mark-UrrBsZIrrsb10XsdtD+oqA@public.gmane.org>
To: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 7/7] Don't require latency_warn_ms from bcache_util.o
Date: Sat, 10 Sep 2011 14:45:39 +0100	[thread overview]
Message-ID: <1315662339-3115-7-git-send-email-mark@pogo.org.uk> (raw)
In-Reply-To: <1315662339-3115-1-git-send-email-mark-UrrBsZIrrsb10XsdtD+oqA@public.gmane.org>

When building as a module, we can't see this variable. This removes
useful debugging; probably some restructuring would be better here.

I'm not clear on the responsibilities of bcache.c, vs. bcache_util.c,
there seem to be references in both directions.
---
 block/bcache_util.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/block/bcache_util.c b/block/bcache_util.c
index b014e8c..11a81c0 100644
--- a/block/bcache_util.c
+++ b/block/bcache_util.c
@@ -378,8 +378,6 @@ void closure_put(struct closure *c, struct workqueue_struct *wq)
 	bool sleeping;
 	int r;
 again:
-	pr_latency(c->wait_time, "%pf", c->fn);
-
 	sleeping = test_bit(__CLOSURE_SLEEPING, &c->flags);
 	r = atomic_dec_return(&c->remaining);
 	smp_mb__after_atomic_dec();
-- 
1.7.4.4

  parent reply	other threads:[~2011-09-10 13:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-10 13:44 First observations with bcache Mark Hills
     [not found] ` <1109101110320.2733-4jfXtw+jRJ582hYKe6nXyg@public.gmane.org>
2011-09-10 13:45   ` [PATCH 1/7] Use exported call to up/down read Mark Hills
     [not found]     ` <1315662339-3115-1-git-send-email-mark-UrrBsZIrrsb10XsdtD+oqA@public.gmane.org>
2011-09-10 13:45       ` [PATCH 2/7] Provide 64-bit arithmetic functions Mark Hills
2011-09-10 13:45       ` [PATCH 3/7] Break fuzz test to allow building as module Mark Hills
2011-09-10 13:45       ` [PATCH 4/7] Don't require linkage against closure_lock Mark Hills
2011-09-10 13:45       ` [PATCH 5/7] Allow closure debugging without CONFIG_DEBUG_FS Mark Hills
2011-09-10 13:45       ` [PATCH 6/7] Temporary fix to pr_latency() Mark Hills
2011-09-10 13:45       ` Mark Hills [this message]
2011-09-10 21:39       ` [PATCH 1/7] Use exported call to up/down read Kent Overstreet
2011-09-22  6:13   ` First observations with bcache Kent Overstreet
2011-09-22 23:14     ` Mark Hills

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315662339-3115-7-git-send-email-mark@pogo.org.uk \
    --to=mark-urrbszirrsb10xsdtd+oqa@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.