From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCHv3] UBI: new module ubiblk: block layer on top of UBI Date: Sun, 11 Sep 2011 13:18:12 +0300 Message-ID: <1315736297.18731.1.camel@sauron> References: <1308922482-14967-1-git-send-email-david.wagner@free-electrons.com> <1315280704.19067.14.camel@sauron> <1315282208.19067.24.camel@sauron> <201109081726.00769.arnd@arndb.de> <1315569206.7905.41.camel@sauron> <4E6A25B1.8070400@free-electrons.com> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:message-id :mime-version; bh=tqZP3FqMHMNGFy1A1oa3d3crQTv+fvX+j9iAfmSm6DU=; b=hBRkV0GGMc5iYURmNsxP8eD/UGIr9tbjUHNRuT/1oQtT2JUFc35GxBeKkgz8pMX6sN /XEk1ahvRgba63saX+I9LZd+Lm5jnJkgkMzsVuHmTB7oBwjevq2xSJ2k2SW/6EmrLhpu 9PbCrw0uqsWorhO6wwe0PGVA8gwmKirgURuEM= In-Reply-To: <4E6A25B1.8070400@free-electrons.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: David Wagner Cc: Arnd Bergmann , linux-embedded , lkml , linux-mtd , Tim Bird , David Woodhouse On Fri, 2011-09-09 at 16:41 +0200, David Wagner wrote: > > 1. Stick with the own cdev approach - the driver becomes very simple > > in this case - we review it. > > This is the way it's implemented in v4, right ? Yes, but I though I sent you some feed back with minor things as well as with major issue related to race condigions: you should keep the UBI volume open as long as your block device is referenced, to prevent the UBI volume from being removed. -- Best Regards, Artem Bityutskiy ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz0-f41.google.com ([209.85.210.41]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1R2h4s-0004mR-FO for linux-mtd@lists.infradead.org; Sun, 11 Sep 2011 10:15:55 +0000 Received: by pzk4 with SMTP id 4so6443167pzk.28 for ; Sun, 11 Sep 2011 03:15:48 -0700 (PDT) Subject: Re: [PATCHv3] UBI: new module ubiblk: block layer on top of UBI From: Artem Bityutskiy To: David Wagner Date: Sun, 11 Sep 2011 13:18:12 +0300 In-Reply-To: <4E6A25B1.8070400@free-electrons.com> References: <1308922482-14967-1-git-send-email-david.wagner@free-electrons.com> <1315280704.19067.14.camel@sauron> <1315282208.19067.24.camel@sauron> <201109081726.00769.arnd@arndb.de> <1315569206.7905.41.camel@sauron> <4E6A25B1.8070400@free-electrons.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1315736297.18731.1.camel@sauron> Mime-Version: 1.0 Cc: Arnd Bergmann , linux-embedded , lkml , linux-mtd , Tim Bird , David Woodhouse Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2011-09-09 at 16:41 +0200, David Wagner wrote: > > 1. Stick with the own cdev approach - the driver becomes very simple > > in this case - we review it. > > This is the way it's implemented in v4, right ? Yes, but I though I sent you some feed back with minor things as well as with major issue related to race condigions: you should keep the UBI volume open as long as your block device is referenced, to prevent the UBI volume from being removed. -- Best Regards, Artem Bityutskiy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754085Ab1IKKPu (ORCPT ); Sun, 11 Sep 2011 06:15:50 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:44236 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753809Ab1IKKPt (ORCPT ); Sun, 11 Sep 2011 06:15:49 -0400 Subject: Re: [PATCHv3] UBI: new module ubiblk: block layer on top of UBI From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: David Wagner Cc: Arnd Bergmann , linux-mtd , linux-embedded , lkml , Tim Bird , David Woodhouse Date: Sun, 11 Sep 2011 13:18:12 +0300 In-Reply-To: <4E6A25B1.8070400@free-electrons.com> References: <1308922482-14967-1-git-send-email-david.wagner@free-electrons.com> <1315280704.19067.14.camel@sauron> <1315282208.19067.24.camel@sauron> <201109081726.00769.arnd@arndb.de> <1315569206.7905.41.camel@sauron> <4E6A25B1.8070400@free-electrons.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.2 (3.0.2-3.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1315736297.18731.1.camel@sauron> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-09-09 at 16:41 +0200, David Wagner wrote: > > 1. Stick with the own cdev approach - the driver becomes very simple > > in this case - we review it. > > This is the way it's implemented in v4, right ? Yes, but I though I sent you some feed back with minor things as well as with major issue related to race condigions: you should keep the UBI volume open as long as your block device is referenced, to prevent the UBI volume from being removed. -- Best Regards, Artem Bityutskiy