From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] [dhcp] Use random transaction ID to associate messages
Date: Thu, 15 Sep 2011 17:34:08 +0300
Message-ID: <1316097248.3743.17.camel@lappy>
References: <1441335413.692660.1316096032278.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Hagen Paul Pfeifer <hagen@jauu.net>,
	etherboot-developers@lists.sourceforge.net, jasowang@redhat.com,
	mdc@etherboot.org, ehabkost@redhat.com, kvm@vger.kernel.org,
	Amos Kong <akong@redhat.com>
To: Yaniv Kaul <ykaul@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-fx0-f46.google.com ([209.85.161.46]:42622 "EHLO
	mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752924Ab1IOOem (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 15 Sep 2011 10:34:42 -0400
Received: by fxe4 with SMTP id 4so699183fxe.19
        for <kvm@vger.kernel.org>; Thu, 15 Sep 2011 07:34:40 -0700 (PDT)
In-Reply-To: <1441335413.692660.1316096032278.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2011-09-15 at 10:13 -0400, Yaniv Kaul wrote:
> ----- Original Message -----
> > On Thu, 15 Sep 2011 21:00:38 +0800, Amos Kong <akong@redhat.com>
> > wrote:
> > 
> > > + netdev->xid = random();
> > 
> > This will not work for reboots. The decision that the hardware address
> > is
> > choosen was not accidental. Not sure if some DHCP server will count on
> > the
> > ID. (RFC 2131 "Retain DHCP client configuration across server reboots,
> > and,
> > whenever possible, a DHCP client should be assigned the same
> > configuration
> > parameters despite restarts of the DHCP mechanism"). If not so I am
> > fine
> > with the patch.
> > 
> > Hagen
> 
> But a DHCP client should be identified by its MAC, not the xid.
> Y.

DHCP server may not be aware of MAC address.

-- 

Sasha.