From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [PATCH] policycoreutils: fix sandbox Makefile
From: Guido Trentalancia <guido@trentalancia.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Eric Paris <eparis@parisplace.org>, Eric Paris <eparis@redhat.com>,
        selinux@tycho.nsa.gov
Date: Thu, 15 Sep 2011 19:38:52 +0200
In-Reply-To: <1316106835.16483.32.camel@moss-pluto>
References: <1316026239-27148-1-git-send-email-eparis@redhat.com>
	 <CACLa4ptONKKd2t6eM+CUPeWOWKjrCteiZFFTYYTRwCKiHfROog@mail.gmail.com>
	 <1316106835.16483.32.camel@moss-pluto>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <1316108332.2202.49.camel@vortex>
Mime-Version: 1.0
Sender: owner-selinux@tycho.nsa.gov
List-Id: selinux@tycho.nsa.gov

On Thu, 2011-09-15 at 13:13 -0400, Stephen Smalley wrote:
> Fix sandbox Makefile so that make DESTDIR=~/out install works again.
> 
> Signed-off-by:  Stephen Smalley <sds@tycho.nsa.gov>
> 
> ---
> 
>  policycoreutils/sandbox/Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/policycoreutils/sandbox/Makefile b/policycoreutils/sandbox/Makefile
> index 21df0c4..4566810 100644
> --- a/policycoreutils/sandbox/Makefile
> +++ b/policycoreutils/sandbox/Makefile
> @@ -2,6 +2,7 @@
>  PREFIX ?= ${DESTDIR}/usr
>  INITDIR ?= ${DESTDIR}/etc/rc.d/init.d/
>  SYSCONFDIR ?= ${DESTDIR}/etc/sysconfig
> +LIBDIR ?= $(PREFIX)/lib
>  BINDIR ?= $(PREFIX)/bin
>  SBINDIR ?= $(PREFIX)/sbin
>  MANDIR ?= $(PREFIX)/share/man
> @@ -13,7 +14,7 @@ LDLIBS += -lselinux -lcap-ng
>  all: sandbox seunshare sandboxX.sh start
>  
>  seunshare: seunshare.o $(EXTRA_OBJS)
> -	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS)
> +	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) -L$(LIBDIR)

EXTRA_OBJS is not defined therefore it is empty unless passed from the
command-line...

Perhaps you meant the -L flag goes before the LDLIBS (which is made just
of -l flags) ?

as in: 

-	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS)
+	$(CC) $(LDFLAGS) -o $@ $^ -L$(LIBDIR) $(LDLIBS)

>  install: all
>  	-mkdir -p $(BINDIR)
> 

Guido


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.