All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: James Morris <jmorris@namei.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (security tree related)
Date: Thu, 15 Sep 2011 18:03:51 -0400	[thread overview]
Message-ID: <1316124231.3345.29.camel@localhost.localdomain> (raw)
In-Reply-To: <20110915170715.a380a5be954efc5891386ee3@canb.auug.org.au>

On Thu, 2011-09-15 at 17:07 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> security/keys/encrypted-keys/masterkey_trusted.c: In function 'request_trusted_key':
> security/keys/encrypted-keys/masterkey_trusted.c:35:2: error: implicit declaration of function 'IS_ERR'
> 
> Caused by commit 982e617a313b ("encrypted-keys: remove trusted-keys
> dependency").  Forgot to include linux/err.h.  See Rule 1 in
> Documentation/SubmitChecklist.
> 
> I have applied the following patch for today.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 15 Sep 2011 17:03:09 +1000
> Subject: [PATCH] encrypted-keys: IS_ERR need include/err.h
> 
> Fixes this build error:
> 
> security/keys/encrypted-keys/masterkey_trusted.c: In function 'request_trusted_key':
> security/keys/encrypted-keys/masterkey_trusted.c:35:2: error: implicit declaration of function 'IS_ERR'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  security/keys/encrypted-keys/masterkey_trusted.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/security/keys/encrypted-keys/masterkey_trusted.c b/security/keys/encrypted-keys/masterkey_trusted.c
> index a5da512..df87272 100644
> --- a/security/keys/encrypted-keys/masterkey_trusted.c
> +++ b/security/keys/encrypted-keys/masterkey_trusted.c
> @@ -16,6 +16,7 @@
> 
>  #include <linux/uaccess.h>
>  #include <linux/module.h>
> +#include <linux/err.h>
>  #include <keys/trusted-type.h>
> 
>  /*
> -- 
> 1.7.5.4

Thanks Stephen.  James, assuming that the patch needs to be made
available from the security tree, it's available from:

The following changes since commit 8de6ac7f58a22fdab399fbe97763e465ea49c735:

  Merge branch 'next-evm' of git://github.com/mzohar/linux-evm into next (2011-09-15 09:53:38 +1000)

are available in the git repository at:

  git://github.com/mzohar/linux-evm.git next-for-james

Stephen Rothwell (1):
      encrypted-keys: IS_ERR need include/err.h

 security/keys/encrypted-keys/masterkey_trusted.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

thanks,

Mimi

  reply	other threads:[~2011-09-15 22:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15  7:07 linux-next: build failure after merge of the final tree (security tree related) Stephen Rothwell
2011-09-15 22:03 ` Mimi Zohar [this message]
2011-09-16  0:51   ` James Morris
  -- strict thread matches above, loose matches on Subject: below --
2011-10-14  7:07 Stephen Rothwell
2011-10-14  7:25 ` Sakkinen, Jarkko
2012-04-16  5:46 Stephen Rothwell
2012-04-16 15:32 ` Will Drewry
2012-04-16 15:34   ` Eric Paris
2012-04-16 15:44     ` Will Drewry
2012-04-16 16:15   ` Will Drewry
2012-04-17  1:33     ` James Morris
2012-04-17  2:02       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316124231.3345.29.camel@localhost.localdomain \
    --to=zohar@linux.vnet.ibm.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.