All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guido Trentalancia <guido@trentalancia.com>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: eparis@redhat.com, selinux@tycho.nsa.gov
Subject: Re: [PATCH 51/67] libsepol: Preserve tunables when required by semodule
Date: Fri, 16 Sep 2011 06:55:00 +0200	[thread overview]
Message-ID: <1316148900.2364.33.camel@vortex> (raw)
In-Reply-To: <4E7257FE.6070703@redhat.com>

On Thu, 2011-09-15 at 15:54 -0400, Daniel J Walsh wrote:
> From f2a839faa71dac0bc575615bfe0aafca94a00892 Mon Sep 17 00:00:00 2001
> From: Harry Ciao <qingtao.cao@windriver.com>
> Date: Thu, 1 Sep 2011 11:29:47 +0800
> Subject: [PATCH 51/67] libsepol: Preserve tunables when required by
> semodule
>  program.
> 
> If the "-P/--preserve_tunables" option is set for the semodule
> program,
> the preserve_tunables flag in sepol_handle_t would be set, then all
> tunables
> would be treated as booleans by having their TUNABLE flag bit cleared,
> resulting in all tunables if-else conditionals preserved for raw
> policy.
> 
> Note, such option would invalidate the logic to double-check if
> tunables
> ever mix with booleans in one expression, so skip the call to assert()
> when this option is passed.
> 
> Signed-off-by: Harry Ciao <qingtao.cao@windriver.com>
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---
>  libsepol/src/expand.c |   36 ++++++++++++++++++++++++------------
>  1 files changed, 24 insertions(+), 12 deletions(-) 

Hello Dan.

The new option seems not fully enabled yet by parsing the option and
setting the preserve_tunables flag appropriately in main().

Is it going to be enabled elsewhere ?

Guido


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2011-09-16  4:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 19:54 [PATCH 51/67] libsepol: Preserve tunables when required by semodule Daniel J Walsh
2011-09-16  4:55 ` Guido Trentalancia [this message]
2011-09-16 14:25   ` Daniel J Walsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316148900.2364.33.camel@vortex \
    --to=guido@trentalancia.com \
    --cc=dwalsh@redhat.com \
    --cc=eparis@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.