From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 11/67] policycoreutils: setfiles: FIXME switch from stat to From: Stephen Smalley To: Guido Trentalancia Cc: Daniel J Walsh , eparis@redhat.com, selinux@tycho.nsa.gov In-Reply-To: <1316157190.2364.57.camel@vortex> References: <4E724F22.20402@redhat.com> <1316157190.2364.57.camel@vortex> Content-Type: text/plain; charset="UTF-8" Date: Fri, 16 Sep 2011 08:41:24 -0400 Message-ID: <1316176884.20456.7.camel@moss-pluto> Mime-Version: 1.0 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On Fri, 2011-09-16 at 09:13 +0200, Guido Trentalancia wrote: > On Thu, 2011-09-15 at 15:16 -0400, Daniel J Walsh wrote: > > From 1268e66e94286a55c399383d5959734d3597792d Mon Sep 17 00:00:00 2001 > > From: Eric Paris > > Date: Sun, 10 Jul 2011 16:54:25 +0200 > > Subject: [PATCH 11/67] policycoreutils: setfiles: FIXME switch from > > stat to > > stat64 > > > > This looks bad. glibc takes care of this. We should do send this > > upstream but I would like to know why you did it in Fedora.... > > > > NOT-Signed-off-by: Eric Paris > > --- > > policycoreutils/setfiles/restore.c | 8 ++++---- > > 1 files changed, 4 insertions(+), 4 deletions(-) > > Perhaps you could exploit a few #ifdef's here ? > > Such as _LARGEFILE_SOURCE _LARGEFILE64_SOURCE and/or > _FILE_OFFSET_BITS=64 ? > > More available from: > > info libc 'Feature Test Macros' We were doing that before converting setfiles from using nftw(3) to using fts(3) for the file tree walk. But fts.h has this gem: /* The fts interface is incompatible with the LFS interface which transparently uses the 64-bit file access functions. */ #ifdef __USE_FILE_OFFSET64 # error " cannot be used with -D_FILE_OFFSET_BITS==64" #endif -- Stephen Smalley National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.