All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Guido Trentalancia <guido@trentalancia.com>
Cc: Daniel J Walsh <dwalsh@redhat.com>, selinux@tycho.nsa.gov
Subject: Re: [PATCH 35/67] policycoreutils: sandbox: FIXME add level based kill
Date: Fri, 16 Sep 2011 11:10:21 -0400	[thread overview]
Message-ID: <1316185823.14578.2.camel@localhost> (raw)
In-Reply-To: <1316151193.2364.38.camel@vortex>

On Fri, 2011-09-16 at 07:33 +0200, Guido Trentalancia wrote:
> On Fri, 2011-09-16 at 06:49 +0200, Guido Trentalancia wrote:
> > On Thu, 2011-09-15 at 15:45 -0400, Daniel J Walsh wrote:
> > > @@ -941,6 +1011,9 @@ childerr:
> > >         waitpid(child, &status, 0);
> > >         status_to_retval(status, status);
> > >  
> > > +       if (execcon && kill_all)
> > > +               killall(execcon);
> > > +
> > >         if (tmpdir_r) cleanup_tmpdir(tmpdir_r, tmpdir_s, pwd, 1);
> > >  
> > >  err: 
> > 
> > Was it not just "kill" instead of "kill_all" ?
> 
> I just realised that variable is going to get renamed in another patch
> ([PATCH 36/67] policycoreutils: sandbox: cntrl-c should kill entire). So
> I think this patch requires 36/67, that's it but was not evident at
> first sight.

Thanks, mistake on my part.  Will move the required change from patch
#36 into patch #35 before committing.

-Eric


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      parent reply	other threads:[~2011-09-16 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 19:45 [PATCH 35/67] policycoreutils: sandbox: FIXME add level based kill Daniel J Walsh
2011-09-16  4:49 ` Guido Trentalancia
2011-09-16  5:33   ` Guido Trentalancia
2011-09-16 14:27     ` Daniel J Walsh
2011-09-16 15:10     ` Eric Paris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316185823.14578.2.camel@localhost \
    --to=eparis@redhat.com \
    --cc=dwalsh@redhat.com \
    --cc=guido@trentalancia.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.