All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package.bbclass: fix spurious 'installed but not shipped' warning
Date: Fri, 16 Sep 2011 17:24:25 +0100	[thread overview]
Message-ID: <1316190273.20858.31.camel@ted> (raw)
In-Reply-To: <1316186907.2384.90.camel@elmorro>

On Fri, 2011-09-16 at 10:28 -0500, Tom Zanussi wrote:
> For packages that have files installed that aren't in a subdirectory,
> the following build WARNING is emitted (this for initramfs-live-boot
> as an example):
> 
> WARNING: For recipe initramfs-live-boot, the following files were
>  installed but not shipped in any package:
> WARNING:   init
> 
> The problem is that the filenames added to the 'seen' array are always
> added with a path separator at the beginning of the filename, but when
> the package dir is walked for comparison, any files at the top-level
> will be missing the beginning path separator and the comparison will
> fail despite the fact that the file was actually packaged.  This
> because the remainder between the dirname and the dvar base name is
> used in the path join and in the case of files at the top-level, the
> remainder is the empty string, where it should be '/' for comparison
> purposes.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> ---
>  meta/classes/package.bbclass |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

Good fix, merged to master, thanks.

Richard




      parent reply	other threads:[~2011-09-16 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 15:28 [PATCH] package.bbclass: fix spurious 'installed but not shipped' warning Tom Zanussi
2011-09-16 15:46 ` Otavio Salvador
2011-09-16 16:24 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316190273.20858.31.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.