From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_repair: add printf format checking and fix the fallout
Date: Mon, 19 Sep 2011 17:39:36 -0500 [thread overview]
Message-ID: <1316471976.2941.99.camel@doink> (raw)
In-Reply-To: <20110814201239.GA26453@infradead.org>
On Sun, 2011-08-14 at 16:12 -0400, Christoph Hellwig wrote:
> Add the gcc printf like attribute to the xfs_repair-internal logging helpers,
> and fix the massive fallout. A large part of it is dealing with the correct
> format for fixed size 64-bit types, but there were a lot of real bug in there,
> including some that lead to crashed when repairing certain corrupted
> filesystems on ARM based systems.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Anisse Astier <anisse@astier.eu>
OK, I compiled in these environments:
x86_64: clean build
ia64: some new warnings, eliminated none of the old ones
i686: still a few (non-printf) warnings, but none new
If it weren't for the new warnings I would just say
let's commit this and I can commit fixes for the remaining
warnings separately. But instead I'll send you a patch
privately for you to merge with what you've got.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-09-19 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 20:12 xfs_repair: add printf format checking and fix the fallout Christoph Hellwig
2011-08-29 8:38 ` Christoph Hellwig
2011-08-30 5:22 ` Dave Chinner
2011-08-30 8:57 ` Christoph Hellwig
2011-09-20 18:43 ` xfsprogs: fix some printf() warnings that show up for ia64 builds Alex Elder
2011-09-20 23:05 ` Dave Chinner
2011-09-21 2:02 ` Alex Elder
2011-09-19 22:39 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316471976.2941.99.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.