From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenyi@linux.vnet.ibm.com>) id 1R6H87-0005fA-N0
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:22:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wenyi@linux.vnet.ibm.com>) id 1R6H86-0000zt-NG
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:22:03 -0400
Received: from e23smtp01.au.ibm.com ([202.81.31.143]:51444)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wenyi@linux.vnet.ibm.com>) id 1R6H86-0000zn-3M
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:22:02 -0400
Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247])
	by e23smtp01.au.ibm.com (8.14.4/8.13.1) with ESMTP id p8L7KJv2015515
	for <qemu-devel@nongnu.org>; Wed, 21 Sep 2011 17:20:19 +1000
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p8L7JrMx1396744
	for <qemu-devel@nongnu.org>; Wed, 21 Sep 2011 17:19:56 +1000
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p8L7Ln8m018319
	for <qemu-devel@nongnu.org>; Wed, 21 Sep 2011 17:21:49 +1000
Received: from [9.115.122.37] ([9.115.122.37])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id
	p8L7LlHc017183
	for <qemu-devel@nongnu.org>; Wed, 21 Sep 2011 17:21:48 +1000
From: wenyi <wenyi@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 21 Sep 2011 15:21:05 +0800
Message-ID: <1316589665.20124.3.camel@wayne-ThinkPad-T61>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu: Fix build failure without VNC support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

        Hello!
        
        Qemu 0.15.0 doesn't build with vnc support disabled. The
        following
        patch fixes the problem.
        
        Signed-off-by: Boris Dolgov <address@hidden>
        
        --
        
        --- monitor.c.orig      2011-09-14 18:11:12.235199764 +0400
        +++ monitor.c   2011-09-14 18:12:19.187709823 +0400
        @@ -1200,10 +1200,12 @@ static int add_graphics_client(Monitor *
                 }
                qerror_report(QERR_ADD_CLIENT_FAILED);
                return -1;
        +#ifdef CONFIG_VNC
             } else if (strcmp(protocol, "vnc") == 0) {
                int fd = monitor_get_fd(mon, fdname);
                vnc_display_add_client(NULL, fd, skipauth);
                return 0;
        +#endif
             } else if ((s = qemu_chr_find(protocol)) != NULL) {
                int fd = monitor_get_fd(mon, fdname);
                if (qemu_chr_add_client(s, fd) < 0) {


Yes, the patch works fine.