From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen: change XEN_PLATFORM_PCI to bool default y Date: Wed, 21 Sep 2011 20:08:15 +0100 Message-ID: <1316632095.5182.33.camel@dagon.hellion.org.uk> References: <1316608670-23167-1-git-send-email-stefano.stabellini@eu.citrix.com> <20110921185102.GJ17357@phenom.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110921185102.GJ17357@phenom.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: "jeremy@goop.org" , "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, 2011-09-21 at 19:51 +0100, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 21, 2011 at 01:37:50PM +0100, stefano.stabellini@eu.citrix.com wrote: > > From: Stefano Stabellini > > > > The xen-platform-pci module is small and for PV on HVM guests is a > > How small? IIRC it is single digit numbers of kb. > Does it get removed from memory if it never gets loaded? > > > requirement for xenbus. > > Ok, should it then have a depency on XenBus as well? xenbus can't be a module (which is why allowing platform-pci to be is causing problems). > Linus does not like the 'default y' very much. He actually dislikes > it quite much as I found when he tore Dan's behind about cleancache. In particular case the option is gated on a dependency on another Xen option (PVHVM) which doesn't default on. But if you do select PVHVM you certainly want this option, so I think that's ok (why else would 'default y' even exist?) > .. so I think making it 'default n' is a better option or perhaps > making it depend on some other functionality? Or perhaps just remove > the tristate/bool altogether so it gets activated if XEN_PVHVM > is set? > > Or remove the XEN_PLATFORM_PCI config option completly and make the > config files that build this driver be CONFIG_XENPVHM dependent? That would work too. Even better would be to make it an invisible Kconfig symbol which PVHVM just selects. Ian. > > > > > Signed-off-by: Stefano Stabellini > > --- > > drivers/xen/Kconfig | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > > index 5f7ff8e..a64b8e8 100644 > > --- a/drivers/xen/Kconfig > > +++ b/drivers/xen/Kconfig > > @@ -138,9 +138,9 @@ config XEN_GRANT_DEV_ALLOC > > or as part of an inter-domain shared memory channel. > > > > config XEN_PLATFORM_PCI > > - tristate "xen platform pci device driver" > > + bool "xen platform pci device driver" > > depends on XEN_PVHVM && PCI > > - default m > > + default y > > help > > Driver for the Xen PCI Platform device: it is responsible for > > initializing xenbus and grant_table when running in a Xen HVM > > -- > > 1.7.2.3