From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] qemugl: Use local variable rather than "push" to save register
Date: Thu, 22 Sep 2011 07:47:59 +0100 [thread overview]
Message-ID: <1316674091.2029.1.camel@ted> (raw)
In-Reply-To: <f277242f36a8881f3241489183cfe1e0b4e20671.1316670532.git.edwin.zhai@intel.com>
On Thu, 2011-09-22 at 13:51 +0800, edwin.zhai@intel.com wrote:
> From: Zhai Edwin <edwin.zhai@intel.com>
>
> New gcc uses "%esp" rather than "%ebp" to index local variable in stack, and
> push between save-to/restore-from stack decrease "%esp", which leads wrong
> index. Saving registers via local variables to make gcc aware of this and avoid
> stack disorder.
>
> [YOCTO #1442] got fixed
>
> Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
Merged to master, good catch!
Cheers,
Richard
prev parent reply other threads:[~2011-09-22 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 5:51 [PATCH 0/1] [qemugl] fix opengl calling failure edwin.zhai
2011-09-22 5:51 ` [PATCH 1/1] qemugl: Use local variable rather than "push" to save register edwin.zhai
2011-09-22 6:47 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316674091.2029.1.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.