All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: victorg@ti.com
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Jouni Malinen <j@w1.fi>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFC 3/5] nl80211/cfg80211: adding intermediate scan result event.
Date: Thu, 22 Sep 2011 09:49:37 +0300	[thread overview]
Message-ID: <1316674177.2157.563.camel@cumari> (raw)
In-Reply-To: <4E7AD88C.4020806@ti.com>

On Thu, 2011-09-22 at 09:41 +0300, Victor Goldenshtein wrote: 
> On 21/09/2011 19:38, Johannes Berg wrote:
> 
> >> This could be a little bit problematic, since we need the
> >> rdev->event_work, for the queue_work(), and wdev->event_list to save a
> >> copy of the BSS, or just the mac which will be used to fetch the BSS
> >> before the transmission (still not sure about it ..), and it seems like
> >> these two can be obtained form sdata->dev, so it's look like that we
> >> need this function and it should be in ieee80211_scan_rx.
> >
> > It is not an issue to send a genl message with GFP_ATOMIC.
> >
> 
> 
> The GFP_ATOMIC is for the event info allocation, and not for the genl 
> message, it have to be "GFP_ATOMIC" otherwise we will get kernel warnings.

I guess what Johannes meant is that you can send the genl message in
atomic context, so you don't need to save stuff and use the event work.
You can just send it immediately when cfg80211_inform_bss() and
cfg80211_inform_bss_frame() are called.

I'm not really sure you can send genl messages while atomic, I think I
had problems with that earlier, but you can try. ;)

-- 
Cheers,
Luca.


  reply	other threads:[~2011-09-22  6:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 12:02 [RFC 0/5] Scan optimization Victor Goldenshtein
2011-09-05 12:02 ` [RFC v2 1/5] nl80211/cfg80211: adding 'scan_cancel' command Victor Goldenshtein
2011-09-05 12:05   ` Johannes Berg
     [not found]     ` <4E6736CE.20004@ti.com>
2011-09-07  9:26       ` Johannes Berg
2011-09-05 12:02 ` [RFC v2 2/5] mac80211: " Victor Goldenshtein
2011-09-05 12:06   ` Johannes Berg
2011-09-05 12:02 ` [RFC 3/5] nl80211/cfg80211: adding intermediate scan result event Victor Goldenshtein
2011-09-05 12:08   ` Johannes Berg
2011-09-05 12:08   ` Johannes Berg
     [not found]     ` <4E6736D9.3070804@ti.com>
2011-09-07  9:26       ` Johannes Berg
2011-09-08  6:31         ` Victor Goldenshtein
2011-09-08  6:49           ` Johannes Berg
2011-09-08  8:56             ` Victor Goldenshtein
2011-09-08  9:27               ` Johannes Berg
2011-09-08 14:39                 ` Victor Goldenshtein
2011-09-08 14:42                   ` Johannes Berg
2011-09-21 15:31           ` Jouni Malinen
2011-09-21 15:45             ` Luciano Coelho
2011-09-21 16:28               ` Victor Goldenshtein
2011-09-21 16:38                 ` Johannes Berg
2011-09-22  6:41                   ` Victor Goldenshtein
2011-09-22  6:49                     ` Luciano Coelho [this message]
2011-09-22  7:13                       ` Victor Goldenshtein
2011-09-22  7:15                         ` Luciano Coelho
2011-09-22  7:54                         ` Johannes Berg
2011-09-21  8:19   ` Victor Goldenshtein
2011-09-21  8:35     ` Johannes Berg
2011-09-21  9:03       ` Luciano Coelho
2011-09-21 10:16         ` Johannes Berg
2011-09-05 12:02 ` [RFC 4/5] mac80211: adding intermediate scan result event call Victor Goldenshtein
2011-09-05 12:02 ` [RFC 5/5] nl80211/cfg80211: adding intermediate scan result filter Victor Goldenshtein
2011-09-05 12:11   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316674177.2157.563.camel@cumari \
    --to=coelho@ti.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=victorg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.