From: Peter Zijlstra <peterz@infradead.org>
To: Colin Cross <ccross@android.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 0/3] Replace kmalloc with vmalloc in seq_files
Date: Thu, 22 Sep 2011 23:22:49 +0200 [thread overview]
Message-ID: <1316726569.31040.37.camel@twins> (raw)
In-Reply-To: <1316725029-22737-1-git-send-email-ccross@android.com>
On Thu, 2011-09-22 at 13:57 -0700, Colin Cross wrote:
>
> seq_files are often used for debugging data. When the system is under
> memory pressure, and dumping debugging data starts trying to allocate
> large physically contiguous buffers, it often makes the problem
> worse.
Shouldn't you be using ->next instead of dumping everything in a single
seqop? That way it can return partial buffers and keep state etc.
next prev parent reply other threads:[~2011-09-22 21:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 20:57 [PATCH 0/3] Replace kmalloc with vmalloc in seq_files Colin Cross
2011-09-22 20:57 ` [PATCH 1/3] fs: seq_file: add seq_reserve Colin Cross
2011-09-22 22:54 ` Alan Cox
2011-09-22 23:24 ` Colin Cross
2011-09-22 23:24 ` Colin Cross
2011-09-22 20:57 ` [PATCH 2/3] sched_stats: use the new seq_reserve function Colin Cross
2011-09-22 20:57 ` [PATCH 3/3] seq_file: convert seq buffer to vmalloc Colin Cross
2011-09-22 21:07 ` Joe Perches
2011-09-22 21:19 ` Colin Cross
2011-09-22 21:19 ` Colin Cross
2011-09-22 23:26 ` NamJae Jeon
2011-09-22 21:20 ` Peter Zijlstra
2011-09-22 21:22 ` Peter Zijlstra [this message]
2011-09-22 21:23 ` [PATCH 0/3] Replace kmalloc with vmalloc in seq_files Christoph Hellwig
2011-09-23 0:00 ` Colin Cross
2011-09-23 0:00 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316726569.31040.37.camel@twins \
--to=peterz@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.