All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Clark Williams <williams@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/3][RT] sched: Do not compare cpu masks in scheduler
Date: Mon, 26 Sep 2011 11:26:50 -0400	[thread overview]
Message-ID: <1317050811.26514.7.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20110926150946.844914281@goodmis.org>

On Mon, 2011-09-26 at 11:08 -0400, Steven Rostedt wrote:

Grumble. Quilt seemed to have ignored the From: Peter ... part. 

The last two patches are Peter's not mine. I took his changes from a
patch he gave me on top of my patch.

-- Steve

> plain text document attachment
> (peterz-migrate-disable-no-cpu-compare.patch)
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> 
> Index: linux-rt.git/kernel/sched.c
> ===================================================================
> --- linux-rt.git.orig/kernel/sched.c
> +++ linux-rt.git/kernel/sched.c
> @@ -4235,16 +4235,12 @@ static inline void update_migrate_disabl
>  	 */
>  	mask = tsk_cpus_allowed(p);
>  
> -	WARN_ON(!cpumask_test_cpu(smp_processor_id(), mask));
> +	if (p->sched_class->set_cpus_allowed)
> +		p->sched_class->set_cpus_allowed(p, mask);
> +	p->rt.nr_cpus_allowed = cpumask_weight(mask);
>  
> -	if (!cpumask_equal(&p->cpus_allowed, mask)) {
> -		if (p->sched_class->set_cpus_allowed)
> -			p->sched_class->set_cpus_allowed(p, mask);
> -		p->rt.nr_cpus_allowed = cpumask_weight(mask);
> -
> -		/* Let migrate_enable know to fix things back up */
> -		p->migrate_disable |= MIGRATE_DISABLE_SET_AFFIN;
> -	}
> +	/* Let migrate_enable know to fix things back up */
> +	p->migrate_disable |= MIGRATE_DISABLE_SET_AFFIN;
>  }
>  
>  void migrate_disable(void)



  reply	other threads:[~2011-09-26 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 15:08 [PATCH 0/3][RT] rt: patches to postpone migrate disable Steven Rostedt
2011-09-26 15:08 ` [PATCH 1/3][RT] sched: Postpone actual migration disalbe to schedule Steven Rostedt
2011-09-26 15:08 ` [PATCH 2/3][RT] sched: Do not compare cpu masks in scheduler Steven Rostedt
2011-09-26 15:26   ` Steven Rostedt [this message]
2011-09-26 15:08 ` [PATCH 3/3][RT] sched: Have migrate_disable ignore bounded threads Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317050811.26514.7.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.