From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 6/9] libtool: Fix an issue where unnecessary rpaths were being injected
Date: Mon, 26 Sep 2011 17:57:46 +0100 [thread overview]
Message-ID: <1317056272.26109.66.camel@ted> (raw)
In-Reply-To: <ED60D3CD-738C-4796-B242-F97880DC74FF@dominion.thruhere.net>
On Sun, 2011-09-25 at 18:14 +0200, Koen Kooi wrote:
> Op 25 sep. 2011, om 17:56 heeft Richard Purdie het volgende geschreven:
>
> > libtool was being to aggressive in adding rpath to binaries. This
> > change stops it adding them if that path the default search path.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > meta/recipes-devtools/libtool/libtool-cross_2.4.bb | 2 +-
> > .../recipes-devtools/libtool/libtool-native_2.4.bb | 2 +-
> > .../libtool/libtool-nativesdk_2.4.bb | 2 +-
> > meta/recipes-devtools/libtool/libtool.inc | 3 +-
> > meta/recipes-devtools/libtool/libtool/1 | 55 +++++++++++++++++
> > .../libtool/libtool/fix-rpath.patch | 63 ++++++++++++++++++++
> > meta/recipes-devtools/libtool/libtool_2.4.bb | 2 +-
> > 7 files changed, 124 insertions(+), 5 deletions(-)
> > create mode 100644 meta/recipes-devtools/libtool/libtool/1
> > create mode 100644 meta/recipes-devtools/libtool/libtool/fix-rpath.patch
> >
> > diff --git a/meta/recipes-devtools/libtool/libtool-cross_2.4.bb b/meta/recipes-devtools/libtool/libtool-cross_2.4.bb
> > index 25ac580..6d512b1 100644
> > --- a/meta/recipes-devtools/libtool/libtool-cross_2.4.bb
> > +++ b/meta/recipes-devtools/libtool/libtool-cross_2.4.bb
> > @@ -1,6 +1,6 @@
> > require libtool-${PV}.inc
> >
> > -PR = "r2"
> > +PR = "r4"
> > PACKAGES = ""
> > SRC_URI += "file://prefix.patch"
> >
> > diff --git a/meta/recipes-devtools/libtool/libtool-native_2.4.bb b/meta/recipes-devtools/libtool/libtool-native_2.4.bb
> > index 423622f..3d0998e 100644
> > --- a/meta/recipes-devtools/libtool/libtool-native_2.4.bb
> > +++ b/meta/recipes-devtools/libtool/libtool-native_2.4.bb
> > @@ -2,7 +2,7 @@ require libtool-${PV}.inc
> >
> > DEPENDS = ""
> >
> > -PR = "r2"
> > +PR = "r4"
> > SRC_URI += "file://prefix.patch"
> >
> > inherit native
> > diff --git a/meta/recipes-devtools/libtool/libtool-nativesdk_2.4.bb b/meta/recipes-devtools/libtool/libtool-nativesdk_2.4.bb
> > index 4f67fed..a96d1d1 100644
> > --- a/meta/recipes-devtools/libtool/libtool-nativesdk_2.4.bb
> > +++ b/meta/recipes-devtools/libtool/libtool-nativesdk_2.4.bb
> > @@ -1,6 +1,6 @@
> > require libtool-${PV}.inc
> >
> > -PR = "r2"
> > +PR = "r4"
> > SRC_URI += "file://prefix.patch"
> >
> > inherit nativesdk
> > diff --git a/meta/recipes-devtools/libtool/libtool.inc b/meta/recipes-devtools/libtool/libtool.inc
> > index d423e49..ef9095b 100644
> > --- a/meta/recipes-devtools/libtool/libtool.inc
> > +++ b/meta/recipes-devtools/libtool/libtool.inc
> > @@ -15,7 +15,8 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
> > file://resolve-sysroot.patch \
> > file://use-sysroot-in-libpath.patch \
> > file://fix-final-rpath.patch \
> > - file://avoid_absolute_paths_for_general_utils.patch "
> > + file://avoid_absolute_paths_for_general_utils.patch \
> > + file://fix-rpath.patch "
> >
> > do_compile_prepend () {
> > # Sometimes this file doesn't get rebuilt, force the issue
> > diff --git a/meta/recipes-devtools/libtool/libtool/1 b/meta/recipes-devtools/libtool/libtool/1
> > new file mode 100644
> > index 0000000..b3ee955
> > --- /dev/null
> > +++ b/meta/recipes-devtools/libtool/libtool/1
>
> stray file?
Good catch. I tested this a bit more, liked the results and merged it,
minus this file.
We should notice a lot of the RPATH warnings going away with this
change.
Cheers,
Richard
next prev parent reply other threads:[~2011-09-26 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 15:56 [PATCH 0/9] Various misc fixes/cleanups Richard Purdie
2011-09-25 15:56 ` [PATCH 1/9] gnome-desktop: Ensure we're deterministic about startup-notification dependency Richard Purdie
2011-09-25 15:56 ` [PATCH 2/9] gtk+: Explicitly disable xinerama since we don't have it as a DEPENDS Richard Purdie
2011-09-25 15:56 ` [PATCH 3/9] cairo: Disable bfd symbol loopup since we don't list it in DEPENDS Richard Purdie
2011-09-25 15:56 ` [PATCH 4/9] libsndfile1: Disable external codec librbaries since we don't list " Richard Purdie
2011-09-25 15:56 ` [PATCH 5/9] neon: Add libproxy to DEPENDS to ensure determinstic builds Richard Purdie
2011-09-25 15:56 ` [PATCH 6/9] libtool: Fix an issue where unnecessary rpaths were being injected Richard Purdie
2011-09-25 16:14 ` Koen Kooi
2011-09-26 16:57 ` Richard Purdie [this message]
2011-09-25 15:56 ` [PATCH 7/9] autotools.bbclass: Set the dynamic linker search path for libtool correctly Richard Purdie
2011-09-25 15:57 ` [PATCH 8/9] base.bbclass: Drop legacy code that is no longer useful/used Richard Purdie
2011-09-25 15:57 ` [PATCH 9/9] sstate: No need to spew out a debug message per file, summarise instead Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317056272.26109.66.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.