Re: [PATCH 1/4] conf, recipes: Add new variable LINKER_HASH_STYLE

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-09-28 at 14:24 -0700, Khem Raj wrote:
> On Wed, Sep 28, 2011 at 12:44 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Thu, 2011-09-15 at 18:59 -0700, Khem Raj wrote:
> >> LINKER_HASH_STYLE in OE is set to either 'sysv' or 'gnu'
> >> depending upon processor architecture e.g. mips does not support
> >> gnu hash style so is uses sysv
> >>
> >> besides 'sysv' and 'gnu' third option is to set it to 'both' we do
> >> not do that by default but user can still set it
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  meta/conf/bitbake.conf                      |    3 ++-
> >>  meta/conf/distro/include/tcmode-default.inc |    6 +++++-
> >>  meta/recipes-core/uclibc/uclibc.inc         |    2 +-
> >>  3 files changed, 8 insertions(+), 3 deletions(-)
> >
> > The build failure we're seeing on mips is related to this change. I'm
> > seeing this from "MACHINE=qemumips bitbake -e":
> >
> > # LINKER_HASH_STYLE_mips64el=sysv
> > LINKER_HASH_STYLE_mips64el="sysv"
> > # LINKER_HASH_STYLE=sysv
> > LINKER_HASH_STYLE="sysv"
> > # LINKER_HASH_STYLE_mips64=sysv
> > LINKER_HASH_STYLE_mips64="sysv"
> > # TARGET_LINK_HASH_STYLE=${@['-Wl,--hash-style=gnu',''][bb.data.getVar('LINKER_HASH_STYLE', d, True) == 'gnu']}
> > TARGET_LINK_HASH_STYLE="-Wl,--hash-style=gnu"
> > # TARGET_LDFLAGS=-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED}
> > export TARGET_LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed"
> >
> > Obviously the problem is TARGET_LINK_HASH_STYLE is that value when
> > LINKER_HASH_STYLE="sysv" :/
> >
> > We need to fix this...
> >
> 
> here is my MACHINE=qemumips bitbake -e run on latest oe-core/master
> http://paste.ubuntu.com/698725/

Right, I found the problem, posted the patch and then decided I'd merge
it rather than have anyone suffer any more broken builds:

http://git.openembedded.org/cgit.cgi/openembedded-core/commit/?id=5839702da70cec32f01e58280629f6bcf74d0034

So I think this should be resolved now.

Cheers,

Richard