From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] mac80211: Allow NO_ACK flag overwrite for injected frames
Date: Thu, 29 Sep 2011 12:21:12 +0200 [thread overview]
Message-ID: <1317291672.3974.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAGXE3d87utQhKifrA8bco14rv9zn3-uZEsDiisg8wkDfipeBMQ@mail.gmail.com> (sfid-20110929_120247_235174_E8D6A29A)
On Thu, 2011-09-29 at 12:02 +0200, Helmut Schaa wrote:
> > Makes sense, but I wonder if we really should continue using
> > radiotap :-) Maybe mgmt-tx in nl80211 would be appropriate.
An nl80211 flag, and the right modifications in hostapd to use mgmt-tx
and the flag. But I guess that's just another thing on the growing list
of things to do to move hostapd to not use monitor interfaces ...
> Hmm, not sure how much work that would be ...
>
> >> @@ -1257,7 +1265,7 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
> >> tx->flags |= IEEE80211_TX_UNICAST;
> >> if (unlikely(local->wifi_wme_noack_test))
> >> info->flags |= IEEE80211_TX_CTL_NO_ACK;
> >> - else
> >> + else if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
> >> info->flags &= ~IEEE80211_TX_CTL_NO_ACK;
> >
> > ??
>
> Don't remove the IEEE80211_TX_CTL_NO_ACK flag when it was set via radiotap.
Well, ok, but the logic is:
if (flag not set)
unset flag
which is kinda useless, right?
johannes
next prev parent reply other threads:[~2011-09-29 10:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 9:27 [PATCH] mac80211: Allow NO_ACK flag overwrite for injected frames Helmut Schaa
2011-09-29 9:59 ` Johannes Berg
2011-09-29 10:02 ` Helmut Schaa
2011-09-29 10:21 ` Johannes Berg [this message]
2011-09-29 10:50 ` Helmut Schaa
2011-09-29 11:42 ` [PATCHv2] mac80211: Allow noack " Helmut Schaa
2011-10-27 19:30 ` Johannes Berg
2011-10-28 3:46 ` Helmut Schaa
2011-10-07 8:56 ` [PATCH] mac80211: Allow NO_ACK " Johannes Berg
2011-10-07 9:43 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317291672.3974.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.