All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 04/13] libx11: upgrade to 1.4.4
Date: Fri, 30 Sep 2011 12:24:18 +0100	[thread overview]
Message-ID: <1317381864.12332.163.camel@ted> (raw)
In-Reply-To: <206cf15c98897c551720e9510ff58f644b2cd304.1317367429.git.Martin.Jansa@gmail.com>

On Fri, 2011-09-30 at 09:27 +0200, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  .../xorg-lib/libx11-1.4.4/keysymdef_include.patch  |   19 +++++++
>  .../libx11-1.4.4/x11_disable_makekeys.patch        |   29 +++++++++++
>  meta/recipes-graphics/xorg-lib/libx11.inc          |   52 ++++++++++++--------
>  meta/recipes-graphics/xorg-lib/libx11_1.4.4.bb     |   14 +++++
>  4 files changed, 94 insertions(+), 20 deletions(-)
>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11-1.4.4/keysymdef_include.patch
>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11-1.4.4/x11_disable_makekeys.patch
>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11_1.4.4.bb

This isn't an upgrade, its an addition of a new version with changes to
the core include file which likely break the previous version?

+# Below option is added to overcome the GCC bug on ARM
+# see http://gcc.gnu.org/PR42981 for further details.
+# We could potentially take it off when its fixed in gcc 4.5
+
+CFLAGS_append_arm = " -fforward-propagate "

This shouldn't really be here, it should be in the toolchain config
file, only applied for gcc 4.5 with something like:

CFLAGS_append_arm_pn-libx11 = " -fforward-propagate "

Also, there is a lot of whitespace churn in variables being added and
removed in different orders. Can we reduce that please?

Cheers,

Richard




  reply	other threads:[~2011-09-30 11:29 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30  7:26 [PATCH 00/13] Xorg related changes Martin Jansa
2011-09-30  7:27 ` [PATCH 01/13] xserver-xf86: upgrade to 1.11.0 and move shared definitions to .inc files Martin Jansa
2011-09-30 11:16   ` Richard Purdie
2011-09-30  7:27 ` [PATCH 02/13] xserver-xf86-dri-lite: remove COMPATIBLE_HOST Martin Jansa
2011-10-03 20:10   ` Khem Raj
2011-10-04  7:11     ` Martin Jansa
2011-09-30  7:27 ` [PATCH 03/13] libxft, libxrender, renderproto: add native BBCLASSEXTEND Martin Jansa
2011-09-30  7:27 ` [PATCH 04/13] libx11: upgrade to 1.4.4 Martin Jansa
2011-09-30 11:24   ` Richard Purdie [this message]
2011-09-30  7:27 ` [PATCH 05/13] default-providers: define PREFERRED_PROVIDER_virtual/libx11-native Martin Jansa
2011-09-30 11:07   ` Richard Purdie
2011-09-30  7:27 ` [PATCH 06/13] xorg-app-common: merge some changes from meta-oe Martin Jansa
2011-09-30  7:27 ` [PATCH 07/13] xorg-driver: rename .inc files and " Martin Jansa
2011-09-30  7:27 ` [PATCH 08/13] xf86-video-omapfb: bump SRCREV and add patch " Martin Jansa
2011-09-30  7:27 ` [PATCH 09/13] xserver-nodm-init: merge some changes " Martin Jansa
2011-09-30  9:17   ` Richard Purdie
2011-09-30 10:52     ` Martin Jansa
2011-09-30 11:10       ` Andrea Adami
2011-09-30  7:27 ` [PATCH 10/13] rgb: import from meta-oe layer Martin Jansa
2011-09-30  7:27 ` [PATCH 11/13] libdrm: improve packaging Martin Jansa
2011-09-30 11:03   ` Richard Purdie
2011-09-30 11:10     ` Martin Jansa
2011-09-30  7:27 ` [PATCH 12/13] glx-use-tls: add from meta-oe layer Martin Jansa
2011-09-30 11:15   ` Richard Purdie
2011-09-30  7:27 ` [PATCH 13/13] mesa: upgrade to 7.11 Martin Jansa
2011-09-30 11:18   ` Richard Purdie
2011-09-30  7:28 ` [PATCH 00/13] Xorg related changes Martin Jansa
2011-09-30 11:28 ` Richard Purdie
2011-09-30 11:31   ` Martin Jansa
2011-10-03 10:38   ` Martin Jansa
2011-10-03 10:51     ` Richard Purdie
2011-10-03 13:28     ` [PATCHv2 00/30] " Martin Jansa
2011-10-03 13:28       ` [PATCHv2 01/30] libxft, libxrender, renderproto: add native BBCLASSEXTEND Martin Jansa
2011-10-03 13:28       ` [PATCHv2 02/30] xorg-app-common: merge some changes from meta-oe Martin Jansa
2011-10-03 13:28       ` [PATCHv2 03/30] xorg-driver: rename .inc files and " Martin Jansa
2011-10-03 13:28       ` [PATCHv2 04/30] xf86-video-omapfb: bump SRCREV and add patch " Martin Jansa
2011-10-03 16:00         ` Phil Blundell
2011-10-04  7:28           ` Martin Jansa
2011-10-04  9:43             ` Phil Blundell
2011-10-03 13:28       ` [PATCHv2 05/30] libdrm: improve packaging Martin Jansa
2011-10-03 13:28       ` [PATCHv2 06/30] xserver/mesa: Bump PR after libdrm packaging changes Martin Jansa
2011-10-03 13:28       ` [PATCHv2 07/30] rgb: import from meta-oe layer Martin Jansa
2011-10-03 13:28       ` [PATCHv2 08/30] xserver-xf86-dri-lite: remove old git recipe Martin Jansa
2011-10-03 13:28       ` [PATCHv2 09/30] xserver-xf86: improve packaging and move shared definitions to .inc files Martin Jansa
2011-10-03 13:28       ` [PATCHv2 10/30] xserver-xf86: add new version 1.11.1 Martin Jansa
2011-10-03 13:28       ` [PATCHv2 11/30] xserver-xf86: remove old 1.10.1 version Martin Jansa
2011-10-03 13:28       ` [PATCHv2 12/30] xserver-xf86-dri-lite: remove COMPATIBLE_HOST Martin Jansa
2011-10-03 13:28       ` [PATCHv2 13/30] xserver-xf86: drop unused files Martin Jansa
2011-10-03 13:28       ` [PATCHv2 14/30] xserver-xf86: move patches to xserver-xf86-dri-lite-1.11.1 and use same directory from xserver-xf86-lite recipe Martin Jansa
2011-10-03 13:28       ` [PATCHv2 15/30] xserver-xf86(-dri)-lite: rename to xserver-xorg and xserver-xorg-lite Martin Jansa
2011-10-03 13:28       ` [PATCHv2 16/30] xserver-kdrive: drop unused files (same files are in xserver-kdrive-1.7.99.2 directory Martin Jansa
2011-10-03 13:28       ` [PATCHv2 17/30] xorg-driver-common: bump INC_PR to rebuild drivers agains new xserver-xorg ABI Martin Jansa
2011-10-03 13:28       ` [PATCHv2 18/30] libx11: package xcb, merge few changes from meta-oe Martin Jansa
2011-10-03 13:28       ` [PATCHv2 19/30] libx11: add new version 1.4.4 Martin Jansa
2011-10-03 13:28       ` [PATCHv2 20/30] libx11: remove older 1.3.4 Martin Jansa
2011-10-03 13:28       ` [PATCHv2 21/30] libx11: drop old 1.2.2 git version Martin Jansa
2011-10-03 13:28       ` [PATCHv2 22/30] libx11-trim: move files for libx11-trim from libx11-1.3.4 to libx11-trim-1.3.4 Martin Jansa
2011-10-03 13:28       ` [PATCHv2 23/30] libx11-diet: move old patches used only by libx11-diet-1.3 to separate directory Martin Jansa
2011-10-03 13:28       ` [PATCHv2 24/30] libx11-diet: add SRC_URI checksums Martin Jansa
2011-10-03 13:28       ` [PATCHv2 25/30] xserver-nodm-init: merge some changes from meta-oe Martin Jansa
2011-10-03 13:28       ` [PATCHv2 26/30] glx-use-tls: add from meta-oe layer Martin Jansa
2011-10-03 15:02         ` Phil Blundell
2011-10-03 15:09           ` Martin Jansa
2011-10-04 12:00             ` Richard Purdie
2011-10-13 19:46             ` Phil Blundell
2011-10-14  0:09               ` Khem Raj
2011-10-14  8:40                 ` Martin Jansa
2011-10-14 20:44                   ` Khem Raj
2011-10-03 13:28       ` [PATCHv2 27/30] mesa: add mesa-dri.inc and mesa-xlib.inc with shared options, move uclibc.patch Martin Jansa
2011-10-03 13:28       ` [PATCHv2 28/30] mesa-dri-glsl-native: drop recipe which wasn't usefull since 7.8.2 was removed Martin Jansa
2011-10-03 13:29       ` [PATCHv2 29/30] mesa: add new version 7.11 Martin Jansa
2011-10-12 22:03         ` Richard Purdie
2011-10-03 13:29       ` [PATCHv2 30/30] mesa: drop older 7.10.2 and 7.7+git recipes Martin Jansa
2011-10-04 10:23       ` [PATCHv2 00/30] Xorg related changes Richard Purdie
2011-10-04 10:52         ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317381864.12332.163.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.