From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932249Ab1JCQAN (ORCPT ); Mon, 3 Oct 2011 12:00:13 -0400 Received: from casper.infradead.org ([85.118.1.10]:53821 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932227Ab1JCP77 convert rfc822-to-8bit (ORCPT ); Mon, 3 Oct 2011 11:59:59 -0400 Subject: Re: [V7][PATCH 0/6] x86, nmi: new NMI handling routines From: Peter Zijlstra To: Don Zickus Cc: x86@kernel.org, Andi Kleen , Robert Richter , ying.huang@intel.com, LKML , paulmck@linux.vnet.ibm.com, avi@redhat.com, jeremy@goop.org Date: Mon, 03 Oct 2011 17:59:08 +0200 In-Reply-To: <20111003155655.GG5795@redhat.com> References: <1317409584-23662-1-git-send-email-dzickus@redhat.com> <1317657158.20367.30.camel@twins> <20111003155655.GG5795@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.0.3- Message-ID: <1317657548.20367.33.camel@twins> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-10-03 at 11:56 -0400, Don Zickus wrote: > On Mon, Oct 03, 2011 at 05:52:38PM +0200, Peter Zijlstra wrote: > > > > Also fixed: > > > > drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_nmi’: > > drivers/char/ipmi/ipmi_watchdog.c:1091: error: ‘NMI_HANDLED’ undeclared (first use in this function) > > drivers/char/ipmi/ipmi_watchdog.c:1091: error: (Each undeclared identifier is reported only once > > drivers/char/ipmi/ipmi_watchdog.c:1091: error: for each function it appears in.) > > drivers/char/ipmi/ipmi_watchdog.c:1096: error: ‘NMI_DONE’ undeclared (first use in this function) > > drivers/char/ipmi/ipmi_watchdog.c: In function ‘check_parms’: > > drivers/char/ipmi/ipmi_watchdog.c:1280: error: implicit declaration of function ‘register_nmi_handler’ > > drivers/char/ipmi/ipmi_watchdog.c:1280: error: ‘NMI_UNKNOWN’ undeclared (first use in this function) > > drivers/char/ipmi/ipmi_watchdog.c:1289: error: implicit declaration of function ‘unregister_nmi_handler’ > > drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_wdog_init’: > > drivers/char/ipmi/ipmi_watchdog.c:1327: error: ‘NMI_UNKNOWN’ undeclared (first use in this function) > > drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_wdog_exit’: > > drivers/char/ipmi/ipmi_watchdog.c:1348: error: ‘NMI_UNKNOWN’ undeclared (first use in this function) > > Wow. Sorry about that. I compiled my changes before I submitted. I guess > next time I should 'make clean' before compiling to catch these. I didn't need that, I build an allnoconfig (which got me a fail with the IBS patches), then an allyesconfig (which got me the earlier fail) and this came from my regular config which included the ipmi crap because Ingo hit this same fail earlier (-v5 or so) and everybody forgot to tell you :/ Anyway, no worries, they're all pretty trivial.. now all I need is to convince Ingo to take them :-)