From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH] multipath: get right sysfs value for
	checker_timeout
Date: Wed, 05 Oct 2011 22:45:31 +0200
Message-ID: <1317847531.32002.2.camel@lapoo.opensvc.com>
References: <20111005041505.GQ24133@ether.msp.redhat.com>
Reply-To: christophe.varoqui@opensvc.com,
        device-mapper development <dm-devel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dm-devel-bounces@redhat.com>
In-Reply-To: <20111005041505.GQ24133@ether.msp.redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/dm-devel>
List-Post: <mailto:dm-devel@redhat.com>
List-Help: <mailto:dm-devel-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=subscribe>
Sender: dm-devel-bounces@redhat.com
Errors-To: dm-devel-bounces@redhat.com
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
List-Id: dm-devel.ids

On mar., 2011-10-04 at 23:15 -0500, Benjamin Marzinski wrote:
> sysfs_get_timeout() wasn't looking in the correct directory for the
> checker timeout value. It was looking at .../block/<devname>/timeout,
> instead of  .../block/<devname>/device/timeout
> 
Merged.

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  libmultipath/discovery.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: multipath-tools-110916/libmultipath/discovery.c
> ===================================================================
> --- multipath-tools-110916.orig/libmultipath/discovery.c
> +++ multipath-tools-110916/libmultipath/discovery.c
> @@ -166,7 +166,7 @@ sysfs_get_timeout(struct sysfs_device *d
>  	if (safe_sprintf(attr_path, "%s/device", dev->devpath))
>  		return 1;
>  
> -	len = sysfs_attr_get_value(dev->devpath, "timeout", attr, NAME_SIZE);
> +	len = sysfs_attr_get_value(attr_path, "timeout", attr, NAME_SIZE);
>  	if (!len) {
>  		condlog(3, "%s: No timeout value in sysfs", dev->devpath);
>  		return 1;