From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F131DDC15 for ; Thu, 6 Feb 2025 18:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738865757; cv=none; b=gpVNMNwLvRKHnBFy83UFqQFPltUe6Bnl+Lf5iPX4WXQCGMEGtG4XoLn6mE0f/gR4b+0NDOESC0MgvIAanDMVXJnIezgcbx71dVzyLy+sVcvCYex+AykQ0/Qo8CatYewCkAhiWgxePI/BLCdOhNwNQu4QNVpyaqoLcVl7M3LVJao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738865757; c=relaxed/simple; bh=Nis/b+J0SYgvYxZLZB6eP4P2aFM4J5YLZiAl49pRWwc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TtlqGoUDQXGv8eieJPBvPZCvjXap83QIBhS8BxCY+M33DSTZla9jErz3l1edoQKzwv0RbjUXwwKObXcCe14JE7q2fIBmqNnhIormPDYgbhsdcsluFHmB2vddJYVB+jQCFUiieRgo2DMN5v4CZYBr72Ffu1JQlZxQdGvcTFhXHX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=JU/EQGz2; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="JU/EQGz2" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-71e2aa8d5e3so724168a34.2 for ; Thu, 06 Feb 2025 10:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738865753; x=1739470553; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=rNbgEviF+CZn15hW+HgAJQKpAxd8bo6rNEtjiUZJmnE=; b=JU/EQGz25DYK+hC5SIP5mFh4Uk0Juj+kD/QI3iEbWiG25q9guotkYqQFckqfVaKpoy XIsEXGxxjyAXug9v1MLbetiqM7uI7Ku1bP68RrGHLPiD0JuqAbvg8+Z6F6FRMs0zljxp cRLYvCgcU54urajPejsX3NrNrpnGu7zJNqc68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738865753; x=1739470553; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rNbgEviF+CZn15hW+HgAJQKpAxd8bo6rNEtjiUZJmnE=; b=rd/LAp4jkNJVF8sBfJWqBLdFyFoXB5g1h4B5+xOAwBTj3pabhQcnSHizly/bDfNVIO tYLNO34wXcpcTUGD6x58d+RYhYF06UbK7JfDnNjdCfVDhxj4mWXgoDVVp/4cFXLZx47F cBrkhxc28LRuPKTZdTa8k/07EYqUEupNKYm/zLUONYeXk8PIdPJ5s56t+QG8YiH1dEsh yc2CruDSObBM08dLflfx73VbLPtlO0WucoXGcHVm0zzMHGRt8IkMgJX++MxsvvZnnli9 tVyS33KxfbXv0NrH4dZy0dpwi4fdNw9DjABaMOhrcDWbLN/9RS/QBIeMVVdj1W2NBNs7 Rdug== X-Gm-Message-State: AOJu0YwbFPgEzTVYgvYwfZPjXgxBq5rXO5A1QMMRYixFUvtPPjPBNm2w vrky7myYrrR4JJW0SKvUUiVYf0kX0sN+t50zAXuGhVOO+Of9wKdzxQvBpsoR1g== X-Gm-Gg: ASbGncvrfz46pNaCcM3xQEJXS92q3qUwswMK6Zx68FC2PxGFQPCYo10gTYd4k0dGRM/ Oow3QhZgTyvzIguj9SknxrJRmaKtluacygA4/0dqUvt8ko74b78FFuRuhrkDtyWVYqefwUdNMn0 WGq334iHG6+qZNC7KH1yDhbsZ3lOkIkQ8W6tu0TSVK/8eGLcsUm/h8VgBj+yvWUDjFvwokL+KuS AXzeOkAL9jycpyWWpiVoBy4iIX8RNwd7RYT4iSbu+EJDso08N1nQSPZNrfkmgr5l2XGKsP2s64C 9n8Kzpju/hoLWJDB7DKGkye1T0iIUJN9L2UmQ9wAqzb/MJHVCm9SeQQ= X-Google-Smtp-Source: AGHT+IGPmOIqm0XZjK4ZCqGGZFGR0fmlbWx54bBI0aPyoz+SJBkRnz/TRUo3WVBJUQrW3KZddWyV/w== X-Received: by 2002:a05:6830:2107:b0:71f:b4e0:fa with SMTP id 46e09a7af769-726b8880229mr65717a34.18.1738865753589; Thu, 06 Feb 2025 10:15:53 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726afa4d2b7sm400158a34.63.2025.02.06.10.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2025 10:15:52 -0800 (PST) Message-ID: <1317d50b-8302-4936-b56c-7a9f5b3970b9@broadcom.com> Date: Thu, 6 Feb 2025 10:15:50 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] net: dsa: b53: Enable internal GPHY on BCM63268 To: Kyle Hendry , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250206043055.177004-1-kylehendrydev@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250206043055.177004-1-kylehendrydev@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kyle, On 2/5/25 20:30, Kyle Hendry wrote: > Some BCM63268 bootloaders do not enable the internal PHYs by default. > This patch series adds functionality for the switch driver to > configure the gigabit ethernet PHY. > > Signed-off-by: Kyle Hendry So the register address you are manipulating logically belongs in the GPIO block (GPIO_GPHY_CTRL) which has become quite a bit of a sundry here. I don't have a strong objection about the approach picked up here but we will need a Device Tree binding update describing the second (and optional) register range. Thanks -- Florian