All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bojan Smojver <bojan@rexursive.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] PM / Hibernate: NULL dereferences on error paths
Date: Fri, 07 Oct 2011 20:58:18 +0000	[thread overview]
Message-ID: <1318021098.1965.1.camel@shrek.rexursive.com> (raw)
In-Reply-To: <20111007132453.GA31424@elgon.mountain>

On Fri, 2011-10-07 at 16:24 +0300, Dan Carpenter wrote:
> These lines break if "data" is NULL.
>         if (data[thr].thr)
>                 kthread_stop(data[thr].thr); 

Thanks - good catch. I'm an idiot. Will fix.

This whole thing has been pulled for now, because Rafael got some panics
with it. I'm working on a new patch that will also produce a SHA1 of the
image, so that we know for sure we read in the right thing.

-- 
Bojan


  reply	other threads:[~2011-10-07 20:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07 13:24 [patch] PM / Hibernate: NULL dereferences on error paths Dan Carpenter
2011-10-07 20:58 ` Bojan Smojver [this message]
2011-10-08 10:25 ` Bojan Smojver
2011-10-08 10:28 ` Bojan Smojver
2011-10-08 10:49 ` Dan Carpenter
2011-10-08 13:11 ` Bojan Smojver
2011-10-09 14:11 ` Dan Carpenter
2011-10-09 22:26 ` Bojan Smojver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318021098.1965.1.camel@shrek.rexursive.com \
    --to=bojan@rexursive.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.