From: Dave Reisner <d@falconindy.com>
To: util-linux@vger.kernel.org
Cc: Dave Reisner <dreisner@archlinux.org>
Subject: [PATCH 2/2] mountpoint: fallback on stat when /proc isn't mounted
Date: Sat, 8 Oct 2011 23:31:51 -0400 [thread overview]
Message-ID: <1318131111-30395-2-git-send-email-dreisner@archlinux.org> (raw)
In-Reply-To: <1318131111-30395-1-git-send-email-dreisner@archlinux.org>
mountpoint will fail when /proc isn't available, which lessens its
usefulness as a tool to detect mountpoints. In this case, mimic what
sysvinit's mountpoint tool does and compare the device and inode values
of root and specified target.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
---
Rationale: I think this patch is especially important for folks who are still
using sysvinit. Particularly in the case of a user not having an initramfs, the
userspace initscripts need to be able to detect, without fail, the presence of
/proc, /sys, and /dev being mounted (and mount them when they aren't). While
checking for /proc first and mounting it when mountpoint returns failure will
result in the correct action, it's reliant on broken behavior -- that is,
mountpoint returned false because /proc isn't mounted, not because /proc isn't
a mountpoint.
sys-utils/mountpoint.c | 15 +++++++++++++--
1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/sys-utils/mountpoint.c b/sys-utils/mountpoint.c
index 065d96b..1297d82 100644
--- a/sys-utils/mountpoint.c
+++ b/sys-utils/mountpoint.c
@@ -46,8 +46,19 @@ static dev_t dir_to_device(const char *spec)
struct libmnt_fs *fs;
dev_t res = (dev_t)-1;
- if (!tb)
- return (dev_t)-1;
+ if (!tb) {
+ struct stat root_st, spec_st;
+
+ /* fallback on using stat when /proc isn't available. return success when
+ * we're examining different devices or encounter an exact match for the
+ * root device */
+ if (stat(spec, &spec_st) == 0 && stat("/", &root_st) == 0 &&
+ root_st.st_dev != spec_st.st_dev ||
+ (root_st.st_dev == spec_st.st_dev && root_st.st_ino == spec_st.st_ino))
+ res = spec_st.st_dev;
+
+ return res;
+ }
fs = mnt_table_find_target(tb, spec, MNT_ITER_BACKWARD);
if (fs && mnt_fs_get_target(fs))
--
1.7.7
next prev parent reply other threads:[~2011-10-09 3:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 3:31 [PATCH 1/2] mountpoint: return dev_t from dir_to_device Dave Reisner
2011-10-09 3:31 ` Dave Reisner [this message]
2011-10-11 8:52 ` [PATCH 2/2] mountpoint: fallback on stat when /proc isn't mounted Karel Zak
2011-10-09 21:23 ` [PATCH 1/2] mountpoint: return dev_t from dir_to_device Dave Reisner
2011-10-11 8:21 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318131111-30395-2-git-send-email-dreisner@archlinux.org \
--to=d@falconindy.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.