All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bojan Smojver <bojan@rexursive.com>
To: rjw@sisk.pl
Cc: linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH v8]: Improve performance of LZO/plain hibernation
Date: Sun, 09 Oct 2011 18:54:19 +1100	[thread overview]
Message-ID: <1318146859.1916.4.camel@shrek.rexursive.com> (raw)
In-Reply-To: <9904162235.1002635820@rexursive.com>

On Sun, 2011-10-09 at 13:57 +1100, Bojan Smojver wrote:
> My CRC32 checks keep failing on resume. 
> I don't get a panic, but still, this should not happen. 

False alarm, actually. My threaded CRC32 code was broken and was not
taking some of the last pages into account. I fixed that now in my code
and indeed CRC32 of the decompressed pages is the same as the one of the
pages before compression.

PS. We are going to lose about 10% of the the speed improvements by
introduction of CRC32 (which will only be used with compression). I
reckon it's still worth it.

-- 
Bojan


  reply	other threads:[~2011-10-09  7:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30  0:27 [PATCH v8]: Improve performance of LZO/plain hibernation Bojan Smojver
2011-10-04 22:07 ` Rafael J. Wysocki
2011-10-05  1:07   ` Bojan Smojver
2011-10-06 18:37     ` Rafael J. Wysocki
2011-10-06 18:45       ` Rafael J. Wysocki
2011-10-06 22:23         ` Bojan Smojver
2011-10-07  3:20         ` Bojan Smojver
2011-10-07  3:39         ` Bojan Smojver
2011-10-07 23:33         ` Bojan Smojver
2011-10-09  2:57         ` Bojan Smojver
2011-10-09  7:54           ` Bojan Smojver [this message]
2011-10-09  9:22         ` Pekka Enberg
2011-10-09 10:19           ` Bojan Smojver
2011-10-09 22:24             ` Bojan Smojver
2011-10-10  7:12             ` Bojan Smojver
2011-10-13 11:00         ` Bojan Smojver
2011-10-13 21:26           ` Rafael J. Wysocki
2011-10-13 21:44             ` Bojan Smojver
2011-10-13 21:57               ` Rafael J. Wysocki
2011-10-13 21:56                 ` Bojan Smojver
2011-10-14  2:01             ` Bojan Smojver
2011-10-14  6:14               ` Pekka Enberg
2011-10-14  6:50                 ` Bojan Smojver
2011-10-15  6:28                 ` Bojan Smojver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318146859.1916.4.camel@shrek.rexursive.com \
    --to=bojan@rexursive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.