From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [PATCH] Import EVO commands into envytools Date: Mon, 10 Oct 2011 09:21:23 +1000 Message-ID: <1318202483.2533.17.camel@nisroch> References: <1318200004-17439-1-git-send-email-maximlevitsky@gmail.com> <1318200004-17439-2-git-send-email-maximlevitsky@gmail.com> Reply-To: skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1318200004-17439-2-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Maxim Levitsky Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On Mon, 2011-10-10 at 00:40 +0200, Maxim Levitsky wrote: > --- > rnndb/nv_evo.xml | 311 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 311 insertions(+), 0 deletions(-) > create mode 100644 rnndb/nv_evo.xml Nice work, comments inlined where appropriate below. > > diff --git a/rnndb/nv_evo.xml b/rnndb/nv_evo.xml > new file mode 100644 > index 0000000..d776dbd > --- /dev/null > +++ b/rnndb/nv_evo.xml > @@ -0,0 +1,311 @@ > + > + + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > + xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd"> > + > + > + > + > + > + > + > + > + Perhaps just call it FLUSH? > + > + > + > + > + > + > + > + > + > + The documentation isn't correct here, but I'm not sure what to write. Nouveau currently uses it for synchronisation, to know when the entire set of queued commands is completely finished, nothing technically to do with the sync channels however. The binary driver uses this in some other ways too, IIRC some magic with 0x8c fills the buffer with data that they read back. But, could be misremembering. A valgrind trace will show what I mean though. > + > + > + > + > + > + > + This is *not* ENABLED, nouveau doesn't even set it. > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + Again, can't be ENABLED. > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + Maybe FREQ_KHZ? > + > + > + > + > + > + > + > + > + > + > + > + BORDER_COLOUR might be more descriptive. > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + We could use the same names here as in NV50_SURFACE_FORMAT in rnndb. I don't have any idea what formats aside from these that EVO accepts, it could be worth checking too. > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + Perhaps reorder. Also, is "4" accepted as a value here on your card? It's TEMPORAL on NVD9. > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + Just FLUSH? > + > + > + > + This is actually 7:4 (IIRC), and should be called SWAP_INTERVAL > + Not 100% sure what this actually is, but it was required in some way to completely disable waiting for vblank before flipping. I'd probably call it "IMMEDIATE" or something. > + > + > + > + > + SEM_ACQUIRE > + SEM_RELEASE > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > +