From: Bojan Smojver <bojan@rexursive.com>
To: linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH v9]: Improve performance of LZO/plain hibernation, check image with CRC32
Date: Mon, 10 Oct 2011 11:10:52 +1100 [thread overview]
Message-ID: <1318205452.1991.23.camel@shrek.rexursive.com> (raw)
On Mon, 2011-10-10 at 10:53 +1100, Bojan Smojver wrote:
> static void release_swap_reader(struct swap_map_handle *handle)
> {
> - if (handle->cur)
> - free_page((unsigned long)handle->cur);
> + struct swap_map_page_list *tmp;
> +
> + while (handle->maps) {
> + if (handle->maps->map)
> + free_page((unsigned long)handle->maps->map);
> + tmp = handle->maps;
> + handle->maps = handle->maps->next;
> + kfree(tmp);
> + }
> handle->cur = NULL;
> + handle->maps = NULL;
> }
Obviously, that handle->maps = NULL is redundant there.
PS. It's funny how errors only become visible once you send them
out. :-)
--
Bojan
next reply other threads:[~2011-10-10 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 0:10 Bojan Smojver [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-10 0:35 [PATCH v9]: Improve performance of LZO/plain hibernation, check image with CRC32 Bojan Smojver
2011-10-09 23:53 Bojan Smojver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318205452.1991.23.camel@shrek.rexursive.com \
--to=bojan@rexursive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.