All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Einon <mark.einon@gmail.com>
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Mark Einon <mark.einon@gmail.com>
Subject: [PATCH 4/4] staging: et131x: Update TODO list
Date: Mon, 10 Oct 2011 16:22:32 +0100	[thread overview]
Message-ID: <1318260152-2786-1-git-send-email-mark.einon@gmail.com> (raw)

Added some more tasks to the TODO list, as highlighted by Francois
Romieu <romieu@fr.zoreil.com>.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
 drivers/staging/et131x/README |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index d383e80..c67f83e 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.
 
 Based on the driver found at https://sourceforge.net/projects/et131x/
 
-Cleaned up immensely by Olaf Hartman and Christoph
-Hellwig <hch@infradead.org>
+Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org>
 
 Note, the powermanagement options were removed from the vendor provided
 driver as they did not build properly at the time.
 
 TODO:
+	- Put the driver into a single file, with a .h for the registers layout.
+	- rx_ring.fbr{0, 1} can probably share a common structure
+	- Use of kmem_cache seems a bit unusual
+	- Use dma_alloc_... in place of pci_alloc_...
+	- It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
+	- PCI_VDEVICE ?
 
 Please send patches to:
 	Greg Kroah-Hartman <gregkh@suse.de>
-- 
1.7.6.4


             reply	other threads:[~2011-10-10 15:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 15:22 Mark Einon [this message]
2011-10-11 14:53 ` [PATCH 4/4] staging: et131x: Update TODO list Nick Bowler
2011-10-11 15:47   ` Mark Einon
2011-10-11 16:07     ` Greg KH
2011-10-11 16:00 ` Ramesh R
2011-10-11 16:11   ` Greg KH
2011-10-11 16:25     ` Mark Einon
2011-10-11 17:25       ` Ramesh R
2011-10-11 18:40         ` Denis Kirjanov
2011-10-12  2:37           ` Ramesh R
2011-10-12  9:10             ` Mark Einon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318260152-2786-1-git-send-email-mark.einon@gmail.com \
    --to=mark.einon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.