From: Luciano Coelho <coelho@ti.com>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 21/29] wl12xx: add band field to wlvif
Date: Mon, 10 Oct 2011 23:38:58 +0300 [thread overview]
Message-ID: <1318279138.9690.421.camel@cumari> (raw)
In-Reply-To: <1318234397-21081-22-git-send-email-eliad@wizery.com>
On Mon, 2011-10-10 at 10:13 +0200, Eliad Peller wrote:
> add band field into the per-interface data.
>
> mac80211 configures some values (e.g. band, channel)
> globally, while we configure them per-interface.
>
> In order to make it easier to keep track of the
> configured value for each value while keeping sync
> with mac80211, save these values both globally
> and per-vif.
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
[...]
> -static int wl12xx_cmd_roc(struct wl1271 *wl, u8 role_id)
> +static int wl12xx_cmd_roc(struct wl1271 *wl, struct wl12xx_vif *wlvif,
> + u8 role_id)
[...]
> -int wl12xx_roc(struct wl1271 *wl, u8 role_id)
> +int wl12xx_roc(struct wl1271 *wl, struct wl12xx_vif *wlvif, u8 role_id)
Seems like wl12xx_roc(), which is the only caller of wl12xx_cmd_roc(),
is always called with wlvif->role_id as the role, so it seems a bit
useless to pass role_id separately all the way.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-10-10 20:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 8:12 [PATCH 00/29] make the driver ready for multi-vif support Eliad Peller
2011-10-10 8:12 ` [PATCH 01/29] wl12xx: refactor fw init into a new function Eliad Peller
2011-10-10 8:12 ` [PATCH 02/29] wl12xx: move last_tx_hlid into wlvif Eliad Peller
2011-10-10 17:52 ` Luciano Coelho
2011-10-10 19:16 ` Eliad Peller
2011-10-10 8:12 ` [PATCH 03/29] wl12xx: unify STA and AP tx_queue mechanism Eliad Peller
2011-10-10 8:12 ` [PATCH 04/29] wl12xx: move some functions from remove_interface() to stop() Eliad Peller
2011-10-10 8:12 ` [PATCH 05/29] wl12xx: move bitrate_masks into wlvif Eliad Peller
2011-10-10 18:20 ` Luciano Coelho
2011-10-10 19:21 ` Eliad Peller
2011-10-10 19:25 ` Luciano Coelho
2011-10-10 8:12 ` [PATCH 06/29] wl12xx: add vifs list Eliad Peller
2011-10-10 18:28 ` Luciano Coelho
2011-10-10 19:29 ` Eliad Peller
2011-10-10 19:40 ` Luciano Coelho
2011-10-10 20:04 ` Johannes Berg
2011-10-10 20:07 ` Eliad Peller
2011-10-10 8:12 ` [PATCH 07/29] wl12xx: support multiple vifs in the tx path Eliad Peller
2011-10-10 8:12 ` [PATCH 08/29] wl12xx: configure sleep_policy according to active roles Eliad Peller
2011-10-10 18:51 ` Luciano Coelho
2011-10-10 19:32 ` Eliad Peller
2011-10-10 19:54 ` Luciano Coelho
2011-10-10 8:12 ` [PATCH 09/29] wl12xx: make event handling support multirole Eliad Peller
2011-10-10 18:58 ` Luciano Coelho
2011-10-10 19:36 ` Eliad Peller
2011-10-10 19:47 ` Luciano Coelho
2011-10-10 8:12 ` [PATCH 10/29] wl12xx: move tx_security_seq into wlvif Eliad Peller
2011-10-10 19:25 ` Luciano Coelho
2011-10-10 8:12 ` [PATCH 11/29] wl12xx: rearm rx streaming per vif Eliad Peller
2011-10-10 8:13 ` [PATCH 12/29] wl12xx: make WL1271_FLAG_STA_ASSOCIATED flag per-vif Eliad Peller
2011-10-10 8:13 ` [PATCH 13/29] wl12xx: make WL1271_FLAG_IBSS_JOINED " Eliad Peller
2011-10-10 8:13 ` [PATCH 14/29] wl12xx: make WL1271_FLAG_AP_STARTED " Eliad Peller
2011-10-10 8:13 ` [PATCH 15/29] wl12xx: make WL1271_FLAG_PSM " Eliad Peller
2011-10-10 8:13 ` [PATCH 16/29] wl12xx: make WL1271_FLAG_STA_STATE_SENT " Eliad Peller
2011-10-10 8:13 ` [PATCH 17/29] wl12xx: make WL1271_FLAG_RX_STREAMING_STARTED " Eliad Peller
2011-10-10 8:13 ` [PATCH 18/29] wl12xx: make WL1271_FLAG_IF_INITIALIZED per-vif Eliad Peller
2011-10-10 8:13 ` [PATCH 19/29] wl12xx: make WL1271_FLAG_PSPOLL_FAILURE flag per-vif Eliad Peller
2011-10-10 8:13 ` [PATCH 20/29] wl12xx: make WL1271_FLAG_CS_PROGRESS " Eliad Peller
2011-10-10 8:13 ` [PATCH 21/29] wl12xx: add band field to wlvif Eliad Peller
2011-10-10 20:38 ` Luciano Coelho [this message]
2011-10-10 20:47 ` Eliad Peller
2011-10-11 9:48 ` Victor Goldenshtein
2011-10-10 8:13 ` [PATCH 22/29] wl12xx: add channel " Eliad Peller
2011-10-10 8:13 ` [PATCH 23/29] wl12xx: add power_level " Eliad Peller
2011-10-10 8:13 ` [PATCH 24/29] wl12xx: make op_config configure all vifs Eliad Peller
2011-10-10 8:13 ` [PATCH 25/29] wl12xx: replace all remaining wl->vif references Eliad Peller
2011-10-10 8:13 ` [PATCH 26/29] wl12xx: call stop() on recovery Eliad Peller
2011-10-10 8:13 ` [PATCH 27/29] wl12xx: use dynamic rate policies Eliad Peller
2011-10-10 8:13 ` [PATCH 28/29] wl12xx: add elp wakeup/sleep calls to add_interface Eliad Peller
2011-10-10 8:13 ` [PATCH 29/29] wl12xx: use round-robin policy for tx Eliad Peller
2011-10-11 12:52 ` [PATCH 00/29] make the driver ready for multi-vif support Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318279138.9690.421.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.