From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Tejun Heo <tj@kernel.org>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
rjw@sisk.pl, bp@amd64.org, pavel@ucw.cz, len.brown@intel.com,
mingo@elte.hu, akpm@linux-foundation.org,
suresh.b.siddha@intel.com, lucas.demarchi@profusion.mobi,
rusty@rustcorp.com.au, rdunlap@xenotime.net,
vatsa@linux.vnet.ibm.com, ashok.raj@intel.com,
tigran@aivazian.fsnet.co.uk, tglx@linutronix.de, hpa@zytor.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/3] Mutually exclude cpu online and suspend/hibernate
Date: Tue, 11 Oct 2011 11:18:34 +0200 [thread overview]
Message-ID: <1318324714.14400.74.camel@laptop> (raw)
In-Reply-To: <20111010170027.GD8100@google.com>
On Mon, 2011-10-10 at 10:00 -0700, Tejun Heo wrote:
> On Mon, Oct 10, 2011 at 06:15:20PM +0530, Srivatsa S. Bhat wrote:
> > Would it be better to hook into the suspend/hibernate notifiers and
> > use them to exclude cpu hotplug from suspend/hibernate, instead of
> > trying to take pm_mutex lock like this?
>
> If this change is determined to be necessary, I think it would be
> better to make it explicit. Exclusion through callbacks often makes
> the locking just more obscure.
Agreed.
next prev parent reply other threads:[~2011-10-11 9:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 12:31 [PATCH v2 0/3] Freezer, CPU hotplug, x86 Microcode: Fix task freezing failures Srivatsa S. Bhat
2011-10-10 12:32 ` [PATCH v2 1/3] Introduce helper functions Srivatsa S. Bhat
2011-10-10 12:33 ` [PATCH v2 2/3] Mutually exclude cpu online and suspend/hibernate Srivatsa S. Bhat
2011-10-10 12:45 ` Srivatsa S. Bhat
2011-10-10 14:26 ` Peter Zijlstra
2011-10-10 15:16 ` Srivatsa S. Bhat
2011-10-11 20:32 ` Srivatsa S. Bhat
2011-10-11 21:56 ` Rafael J. Wysocki
2011-10-12 3:57 ` Srivatsa S. Bhat
2011-10-12 19:31 ` Rafael J. Wysocki
2011-10-12 21:25 ` Srivatsa S. Bhat
2011-10-12 22:09 ` Rafael J. Wysocki
2011-10-13 15:42 ` Srivatsa S. Bhat
2011-10-13 16:06 ` Tejun Heo
2011-10-13 17:01 ` Borislav Petkov
2011-10-13 17:29 ` Srivatsa S. Bhat
2011-10-19 17:29 ` Srivatsa S. Bhat
2011-10-13 18:03 ` Alan Stern
2011-10-13 19:07 ` Rafael J. Wysocki
2011-10-13 19:08 ` Rafael J. Wysocki
2011-10-10 15:25 ` Alan Stern
2011-10-10 17:00 ` Tejun Heo
2011-10-11 9:18 ` Peter Zijlstra [this message]
2011-10-11 9:37 ` Srivatsa S. Bhat
2011-10-10 12:33 ` [PATCH v2 3/3] Update documentation Srivatsa S. Bhat
2011-10-10 15:23 ` [PATCH v2 0/3] Freezer, CPU hotplug, x86 Microcode: Fix task freezing failures Alan Stern
2011-10-10 15:32 ` Srivatsa S. Bhat
2011-10-10 16:53 ` Borislav Petkov
2011-10-10 17:14 ` Pavel Machek
2011-10-10 17:30 ` Srivatsa S. Bhat
2011-10-10 17:53 ` Borislav Petkov
2011-10-10 18:08 ` tj
2011-10-10 18:34 ` Borislav Petkov
2011-10-10 18:45 ` Srivatsa S. Bhat
2011-10-10 18:53 ` tj
2011-10-10 19:00 ` Srivatsa S. Bhat
2011-10-10 20:35 ` Borislav Petkov
[not found] ` <20111010202913.GA30798@aftab>
2011-10-10 21:13 ` tj
2011-10-11 9:17 ` Peter Zijlstra
2011-10-10 16:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318324714.14400.74.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=ashok.raj@intel.com \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=tj@kernel.org \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.