From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/2] mac80211: Build TX radiotap header dynamically
Date: Tue, 11 Oct 2011 18:25:45 +0200 [thread overview]
Message-ID: <1318350345.3965.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1318349335-22514-1-git-send-email-helmut.schaa@googlemail.com> (sfid-20111011_180959_179390_1D9713EA)
On Tue, 2011-10-11 at 18:08 +0200, Helmut Schaa wrote:
> + /* IEEE80211_RADIOTAP_RATE */
> + if (info->status.rates[0].idx >= 0 &&
> + !(info->status.rates[0].flags & IEEE80211_TX_RC_MCS)) {
> + rthdr->it_present |= cpu_to_le32(1 << IEEE80211_RADIOTAP_RATE);
> + *pos = sband->bitrates[info->status.rates[0].idx].bitrate / 5;
> + /* padding for tx flags */
> + pos += 2;
Since there's no over-all memset I think you need to clear the padding
explicitly now.
johannes
next prev parent reply other threads:[~2011-10-11 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 16:08 [PATCH 1/2] mac80211: Build TX radiotap header dynamically Helmut Schaa
2011-10-11 16:08 ` [PATCH 2/2] mac80211: Populate radiotap header with MCS info for TX frames Helmut Schaa
2011-10-11 16:25 ` Johannes Berg [this message]
2011-10-11 17:19 ` Re: [PATCH 1/2] mac80211: Build TX radiotap header dynamically Helmut Schaa
2011-10-11 17:38 ` Johannes Berg
2011-11-18 14:31 ` Johannes Berg
2011-11-18 16:02 ` [PATCH] mac80211: Fix endian bug in radiotap header generation Helmut Schaa
2011-11-18 16:08 ` Johannes Berg
2011-11-18 20:56 ` Helmut Schaa
2011-11-18 20:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318350345.3965.11.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.