All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: make 203 pass on non-default block size filesystems
Date: Thu, 13 Oct 2011 05:35:34 -0500	[thread overview]
Message-ID: <1318502134.3172.19.camel@doink> (raw)
In-Reply-To: <1318212855-20212-3-git-send-email-david@fromorbit.com>

On Mon, 2011-10-10 at 13:14 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> The xfs_bmap output in the golden image is filesystem block size
> dependent. Make all writes 64k to ensure that the allocation/hole
> pattern is consistent across all supported filesystem block sizes.
> 
> Also, use the SCRATCH_DEV instead of the TEST_DEV so that we test
> according to MKFS_OPTIONS rather than test on whatever setup the
> TEST_DEV was created with.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

A minor thing below, which I'll fix for you.
Also one question.  Otherwise looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>

. . .
>  _cleanup()
>  {
> -	rm -f $TEST_DIR/hole_file*

You no longer delete the hole files because there's
no need to (because scratch will likely be clobbered
anyway)?

> -	rm -f $TEST_DIR/r??
> +	rm -f $SCRATCH_DIR/r??

SCRATCH_MNT

(This is an annoyance that ought to be fixed everywhere
I think--either make it SCRATCH_DIR or TEST_MNT.)

. . .


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2011-10-13 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10  2:14 [PATCH 0/2] xfstests: test different block sizes in a couple of tests Dave Chinner
2011-10-10  2:14 ` [PATCH 1/2] xfstests: make 225 use SCRATCH_DEV Dave Chinner
2011-10-10 16:27   ` Christoph Hellwig
2011-10-13 10:35   ` Alex Elder
2011-10-10  2:14 ` [PATCH 2/2] xfstests: make 203 pass on non-default block size filesystems Dave Chinner
2011-10-10 16:27   ` Christoph Hellwig
2011-10-13 10:35   ` Alex Elder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318502134.3172.19.camel@doink \
    --to=aelder@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.