All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/2] nl80211: Add sta_flags to the station info
Date: Thu, 13 Oct 2011 16:43:01 +0200	[thread overview]
Message-ID: <1318516981.5612.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1318516240-10033-1-git-send-email-helmut.schaa@googlemail.com> (sfid-20111013_163117_644066_A3E4DBE3)

On Thu, 2011-10-13 at 16:30 +0200, Helmut Schaa wrote:
> Reuse the already existing struct nl80211_sta_flag_update to specify
> both, a flag mask and the flag set itself. This means
> nl80211_sta_flag_update is now used for setting station flags and also
> for getting station flags.

Why would we care about the mask here? Wouldn't a u32 attribute with the
set flags only make more sense?

johannes


  parent reply	other threads:[~2011-10-13 14:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 14:30 [PATCH 1/2] nl80211: Add sta_flags to the station info Helmut Schaa
2011-10-13 14:30 ` [PATCH 2/2] mac80211: Provide station flags to cfg80211 Helmut Schaa
2011-10-13 14:43 ` Johannes Berg [this message]
2011-10-13 14:54   ` [PATCH 1/2] nl80211: Add sta_flags to the station info Helmut Schaa
2011-10-13 15:00     ` Johannes Berg
2011-10-17 16:39 ` Johannes Berg
2011-10-17 16:43   ` Helmut Schaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318516981.5612.20.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.