From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
David@alsa-project.org, Chen <david.chen@diasemi.com>,
lrg <lrg@ti.com>
Subject: Re: [PATCH v2 2/9] ASoC: da7210: Add support for line input and mic
Date: Fri, 14 Oct 2011 18:06:11 +0530 [thread overview]
Message-ID: <1318595771.12107.542.camel@matrix> (raw)
In-Reply-To: <20111013161959.GI5193@opensource.wolfsonmicro.com>
On Thu, 2011-10-13 at 17:19 +0100, Mark Brown wrote:
> On Thu, Oct 13, 2011 at 07:34:04PM +0530, Ashish Chavan wrote:
> > } else {
> > - /* Volume 7 */
> > - snd_soc_update_bits(codec, DA7210_MIC_L, 0x7, 0x7);
> > - snd_soc_update_bits(codec, DA7210_MIC_R, 0x7, 0x7);
> > -
> > - /* Enable Mic */
> > - snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0x1);
> > - snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0x1);
> > + /* Enable Mic,AUX1 and AUX2 */
> > + snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0xD);
> > + snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0xD);
>
> So, I did mention that the DAPM patch should come first when I reviewed
> your previous series...
>
Posted the series after rearranging the sequence and removing already
merged patch.
Thanks for your time.
prev parent reply other threads:[~2011-10-14 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 14:04 [PATCH v2 2/9] ASoC: da7210: Add support for line input and mic Ashish Chavan
2011-10-13 16:19 ` Mark Brown
2011-10-13 16:19 ` [alsa-devel] " Mark Brown
2011-10-14 12:36 ` Ashish Chavan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318595771.12107.542.camel@matrix \
--to=ashish.chavan@kpitcummins.com \
--cc=David@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.