From: Borislav Petkov <bp@amd64.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: X86-ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 1/2] x86, microcode: Correct microcode revision format
Date: Mon, 17 Oct 2011 17:25:14 +0200 [thread overview]
Message-ID: <1318865115-9904-2-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1318865115-9904-1-git-send-email-bp@amd64.org>
From: Borislav Petkov <borislav.petkov@amd.com>
506ed6b53e00ba303ad778122f08e1fca7cf5efb added microcode revision format
to /proc/cpuinfo and the MCE handler in decimal format but both AMD and
Intel patch levels are handled as hex numbers. Fix it.
Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
arch/x86/kernel/cpu/proc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 8af6fa4..ad8d897 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -221,7 +221,7 @@ static void print_mce(struct mce *m)
* Note this output is parsed by external tools and old fields
* should not be changed.
*/
- pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode %u\n",
+ pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode %x\n",
m->cpuvendor, m->cpuid, m->time, m->socketid, m->apicid,
cpu_data(m->extcpu).microcode);
diff --git a/arch/x86/kernel/cpu/proc.c b/arch/x86/kernel/cpu/proc.c
index 6254fda..14b2314 100644
--- a/arch/x86/kernel/cpu/proc.c
+++ b/arch/x86/kernel/cpu/proc.c
@@ -86,7 +86,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
else
seq_printf(m, "stepping\t: unknown\n");
if (c->microcode)
- seq_printf(m, "microcode\t: %u\n", c->microcode);
+ seq_printf(m, "microcode\t: 0x%x\n", c->microcode);
if (cpu_has(c, X86_FEATURE_TSC)) {
unsigned int freq = cpufreq_quick_get(cpu);
--
1.7.4.rc2
next prev parent reply other threads:[~2011-10-17 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 15:25 [PATCH 0/2] x86, microcode: AMD adjustments Borislav Petkov
2011-10-17 15:25 ` Borislav Petkov [this message]
2011-10-18 6:50 ` [PATCH 1/2] x86, microcode: Correct microcode revision format David Rientjes
2011-10-18 7:51 ` Borislav Petkov
2011-10-18 8:14 ` David Rientjes
2011-10-18 9:48 ` Borislav Petkov
2011-10-18 15:13 ` Andi Kleen
2011-10-18 15:49 ` Borislav Petkov
2011-10-17 15:25 ` [PATCH 2/2] x86, microcode, AMD: Add microcode revision to /proc/cpuinfo Borislav Petkov
2011-10-18 6:25 ` Ingo Molnar
2011-10-19 14:20 ` Borislav Petkov
2011-10-23 11:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318865115-9904-2-git-send-email-bp@amd64.org \
--to=bp@amd64.org \
--cc=ak@linux.intel.com \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.